mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] afs: remove unused variable 'afs_voltypes'
@ 2019-08-09  8:40 YueHaibing
  2019-08-09 17:40 ` Jeffrey E Altman
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-08-09  8:40 UTC (permalink / raw)
  To: dhowells; +Cc: linux-kernel, linux-afs, YueHaibing

fs/afs/volume.c:15:26: warning:
 afs_voltypes defined but not used [-Wunused-const-variable=]

It is not used since commit d2ddc776a458 ("afs: Overhaul
volume and server record caching and fileserver rotation")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 fs/afs/volume.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/afs/volume.c b/fs/afs/volume.c
index 1a41430..92ca5e2 100644
--- a/fs/afs/volume.c
+++ b/fs/afs/volume.c
@@ -12,8 +12,6 @@
 unsigned __read_mostly afs_volume_gc_delay = 10;
 unsigned __read_mostly afs_volume_record_life = 60 * 60;
 
-static const char *const afs_voltypes[] = { "R/W", "R/O", "BAK" };
-
 /*
  * Allocate a volume record and load it up from a vldb record.
  */
-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] afs: remove unused variable 'afs_voltypes'
  2019-08-09  8:40 [PATCH -next] afs: remove unused variable 'afs_voltypes' YueHaibing
@ 2019-08-09 17:40 ` Jeffrey E Altman
  0 siblings, 0 replies; 2+ messages in thread
From: Jeffrey E Altman @ 2019-08-09 17:40 UTC (permalink / raw)
  To: YueHaibing, dhowells; +Cc: linux-kernel, linux-afs


[-- Attachment #1.1: Type: text/plain, Size: 1091 bytes --]

This is true but I believe afs_voltypes should be used in the
afs_put_volume() and afs_deactivate_volume() enter() tracing.

If it will not be used for those calls then removal is correct.

Jeffrey Altman

On 8/9/2019 4:40 AM, YueHaibing wrote:
> fs/afs/volume.c:15:26: warning:
>  afs_voltypes defined but not used [-Wunused-const-variable=]
> 
> It is not used since commit d2ddc776a458 ("afs: Overhaul
> volume and server record caching and fileserver rotation")
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  fs/afs/volume.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/afs/volume.c b/fs/afs/volume.c
> index 1a41430..92ca5e2 100644
> --- a/fs/afs/volume.c
> +++ b/fs/afs/volume.c
> @@ -12,8 +12,6 @@
>  unsigned __read_mostly afs_volume_gc_delay = 10;
>  unsigned __read_mostly afs_volume_record_life = 60 * 60;
>  
> -static const char *const afs_voltypes[] = { "R/W", "R/O", "BAK" };
> -
>  /*
>   * Allocate a volume record and load it up from a vldb record.
>   */
> 

[-- Attachment #1.2: jaltman.vcf --]
[-- Type: text/x-vcard, Size: 283 bytes --]

begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4033 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-09 17:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09  8:40 [PATCH -next] afs: remove unused variable 'afs_voltypes' YueHaibing
2019-08-09 17:40 ` Jeffrey E Altman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®