mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
	axboe@kernel.dk, bvanassche@acm.org, ming.lei@redhat.com,
	nilay@linux.ibm.com, hare@suse.de
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com,
	johnny.chenyi@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v3 0/2] blk-mq: fix update nr_requests regressions
Date: Fri, 5 Sep 2025 15:20:04 +0800	[thread overview]
Message-ID: <f4231a7f-cc73-c506-e30b-b2bfa9d98dba@huaweicloud.com> (raw)
In-Reply-To: <95389918-b809-f81b-5fd0-2e350154ca01@huaweicloud.com>

Hi, Jens

在 2025/08/26 14:27, Yu Kuai 写道:
> Hi, Jens
> 
> 在 2025/08/21 14:06, Yu Kuai 写道:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Changes in v3:
>>   - call depth_updated() directly in init_sched() method in patch 1;
>>   - fix typos in patch 2;
>>   - add review for patch 2;
>> Changes in v2:
>>   - instead of refactor and cleanups and fix updating nr_requests
>>   thoroughly, fix the regression in patch 2 the easy way, and dealy
>>   refactor and cleanups to next merge window.
>>
>> patch 1 fix regression that elevator async_depth is not updated correctly
>> if nr_requests changes, first from error path and then for mq-deadline,
>> and recently for bfq and kyber.
>>
>> patch 2 fix regression that if nr_requests grow, kernel will panic due
>> to tags double free.
>>
>> Yu Kuai (2):
>>    blk-mq: fix elevator depth_updated method
>>    blk-mq: fix blk_mq_tags double free while nr_requests grown
>>
>>   block/bfq-iosched.c   | 22 +++++-----------------
>>   block/blk-mq-sched.h  | 11 +++++++++++
>>   block/blk-mq-tag.c    |  1 +
>>   block/blk-mq.c        | 23 ++++++++++++-----------
>>   block/elevator.h      |  2 +-
>>   block/kyber-iosched.c | 19 +++++++++----------
>>   block/mq-deadline.c   | 16 +++-------------
>>   7 files changed, 42 insertions(+), 52 deletions(-)
>>
> 
> Friendly ping, please consider this set in this merge window.
> 
> BTW, I see that for-6.18/block branch was created, however, I have
> a pending set[1] for the next merge window that will have conflicts with
> this set, not sure if you want to rebase for-6.18/block with block-6.17
> or handle conflicts later for 6.18-rc1.
> 
> [1] 
> https://lore.kernel.org/all/20250815080216.410665-1-yukuai1@huaweicloud.com/ 
> 
Friendly ping ...

Thanks,
Kuai

> 
> Thanks,
> Kuai
> 
> .
> 


  reply	other threads:[~2025-09-05  7:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21  6:06 Yu Kuai
2025-08-21  6:06 ` [PATCH v3 1/2] blk-mq: fix elevator depth_updated method Yu Kuai
2025-08-21 12:21   ` Nilay Shroff
2025-08-21 14:57   ` Li Nan
2025-08-22  6:00   ` Hannes Reinecke
2025-08-21  6:06 ` [PATCH v3 2/2] blk-mq: fix blk_mq_tags double free while nr_requests grown Yu Kuai
2025-08-21 14:57   ` Li Nan
2025-08-22  6:02   ` Hannes Reinecke
2025-08-26  6:27 ` [PATCH v3 0/2] blk-mq: fix update nr_requests regressions Yu Kuai
2025-09-05  7:20   ` Yu Kuai [this message]
2025-09-05 19:52     ` Jens Axboe
2025-09-05 19:54 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4231a7f-cc73-c506-e30b-b2bfa9d98dba@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=johnny.chenyi@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®