* [PATCH 2/2] media: pci: mg4b: use iio_push_to_buffers_with_ts()
[not found] <f65be4fc-0ed2-4b7e-9955-7f64200a51bf@gpxsee.org>
@ 2025-09-08 16:38 ` Martin Tůma
0 siblings, 0 replies; 3+ messages in thread
From: Martin Tůma @ 2025-09-08 16:38 UTC (permalink / raw)
To: jic23, mchehab, linux-iio, linux-kernel, linux-media
On 9/5/25 9:06 PM, David Lechner wrote:
> Replace iio_push_to_buffers_with_timestamp() with
> iio_push_to_buffers_with_ts(). This adds an extra argument with the
> buffer size to ensure that we aren't writing past the end of the buffer.
> No functional change.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Closes: https://lore.kernel.org/linux-iio/20250724115610.011110fb@jic23-huawei/
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
> ---
> drivers/media/pci/mgb4/mgb4_trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/mgb4/mgb4_trigger.c b/drivers/media/pci/mgb4/mgb4_trigger.c
> index bed8bbd4bc595d1d131b9919c6f3b705e43ba3c4..4f9a35904b4186618a554e3047d6b46ff7ed74be 100644
> --- a/drivers/media/pci/mgb4/mgb4_trigger.c
> +++ b/drivers/media/pci/mgb4/mgb4_trigger.c
> @@ -97,7 +97,7 @@ static irqreturn_t trigger_handler(int irq, void *p)
> scan.data = mgb4_read_reg(&st->mgbdev->video, 0xA0);
> mgb4_write_reg(&st->mgbdev->video, 0xA0, scan.data);
>
> - iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp);
> + iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), pf->timestamp);
> iio_trigger_notify_done(indio_dev->trig);
>
> mgb4_write_reg(&st->mgbdev->video, 0xB4, 1U << 11);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] media: pci: mg4b: use iio_push_to_buffers_with_ts()
2025-09-05 19:06 ` [PATCH 2/2] media: pci: mg4b: use iio_push_to_buffers_with_ts() David Lechner
@ 2025-09-07 9:32 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2025-09-07 9:32 UTC (permalink / raw)
To: David Lechner
Cc: Martin Tuma, Mauro Carvalho Chehab, linux-iio, linux-media, linux-kernel
On Fri, 05 Sep 2025 14:06:20 -0500
David Lechner <dlechner@baylibre.com> wrote:
> Replace iio_push_to_buffers_with_timestamp() with
> iio_push_to_buffers_with_ts(). This adds an extra argument with the
> buffer size to ensure that we aren't writing past the end of the buffer.
> No functional change.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Closes: https://lore.kernel.org/linux-iio/20250724115610.011110fb@jic23-huawei/
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> drivers/media/pci/mgb4/mgb4_trigger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/mgb4/mgb4_trigger.c b/drivers/media/pci/mgb4/mgb4_trigger.c
> index bed8bbd4bc595d1d131b9919c6f3b705e43ba3c4..4f9a35904b4186618a554e3047d6b46ff7ed74be 100644
> --- a/drivers/media/pci/mgb4/mgb4_trigger.c
> +++ b/drivers/media/pci/mgb4/mgb4_trigger.c
> @@ -97,7 +97,7 @@ static irqreturn_t trigger_handler(int irq, void *p)
> scan.data = mgb4_read_reg(&st->mgbdev->video, 0xA0);
> mgb4_write_reg(&st->mgbdev->video, 0xA0, scan.data);
>
> - iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp);
> + iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), pf->timestamp);
> iio_trigger_notify_done(indio_dev->trig);
>
> mgb4_write_reg(&st->mgbdev->video, 0xB4, 1U << 11);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] media: pci: mg4b: use iio_push_to_buffers_with_ts()
2025-09-05 19:06 [PATCH 0/2] media: pci: mfb4: iio trigger improvements David Lechner
@ 2025-09-05 19:06 ` David Lechner
2025-09-07 9:32 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: David Lechner @ 2025-09-05 19:06 UTC (permalink / raw)
To: Martin Tuma, Mauro Carvalho Chehab
Cc: linux-iio, linux-media, linux-kernel, Jonathan Cameron, David Lechner
Replace iio_push_to_buffers_with_timestamp() with
iio_push_to_buffers_with_ts(). This adds an extra argument with the
buffer size to ensure that we aren't writing past the end of the buffer.
No functional change.
Suggested-by: Jonathan Cameron <jic23@kernel.org>
Closes: https://lore.kernel.org/linux-iio/20250724115610.011110fb@jic23-huawei/
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/media/pci/mgb4/mgb4_trigger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/mgb4/mgb4_trigger.c b/drivers/media/pci/mgb4/mgb4_trigger.c
index bed8bbd4bc595d1d131b9919c6f3b705e43ba3c4..4f9a35904b4186618a554e3047d6b46ff7ed74be 100644
--- a/drivers/media/pci/mgb4/mgb4_trigger.c
+++ b/drivers/media/pci/mgb4/mgb4_trigger.c
@@ -97,7 +97,7 @@ static irqreturn_t trigger_handler(int irq, void *p)
scan.data = mgb4_read_reg(&st->mgbdev->video, 0xA0);
mgb4_write_reg(&st->mgbdev->video, 0xA0, scan.data);
- iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp);
+ iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), pf->timestamp);
iio_trigger_notify_done(indio_dev->trig);
mgb4_write_reg(&st->mgbdev->video, 0xB4, 1U << 11);
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-08 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <f65be4fc-0ed2-4b7e-9955-7f64200a51bf@gpxsee.org>
2025-09-08 16:38 ` [PATCH 2/2] media: pci: mg4b: use iio_push_to_buffers_with_ts() Martin Tůma
2025-09-05 19:06 [PATCH 0/2] media: pci: mfb4: iio trigger improvements David Lechner
2025-09-05 19:06 ` [PATCH 2/2] media: pci: mg4b: use iio_push_to_buffers_with_ts() David Lechner
2025-09-07 9:32 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®