From: Maxim Kochetkov <fido_max@inbox.ru>
To: phucduc.bui@gmail.com, Andrew Jackson <Andrew.Jackson@arm.com>,
Mark Brown <broonie@kernel.org>,
Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: Tim Bird <tim.bird@sony.com>,
Yuri Zaporozhets <yuriz@vodafonemail.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] ASoC: dwc: Fix bit clock rate in TDM mode
Date: Mon, 9 Nov 2026 10:10:39 +0300 [thread overview]
Message-ID: <f43d21ed-ff7e-40b8-93ff-42808985fac4@inbox.ru> (raw)
In-Reply-To: <20261106112940.53550-2-phucduc.bui@gmail.com>
06.11.2026 14:29, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The bit clock is computed as rate * data_width * 2, which only fits
> a two-slot I2S frame. Use rate * data_width * tdm_slots in TDM mode.
>
> Fixes: 221acc16aee1 ("ASoC: dwc: Add TDM mode support")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> sound/soc/dwc/dwc-i2s.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index dbda943cfaf3..9007ba1157ac 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -331,7 +331,10 @@ static int dw_i2s_hw_params(struct snd_pcm_substream *substream,
> }
> } else {
> u32 bitclk = config->sample_rate *
> - config->data_width * 2;
> + config->data_width * 2;
Should the identation be fixed in a separate commit? It is not related
to TDM clock rate.
> + if (dev->tdm_slots)
> + bitclk = config->sample_rate *
> + config->data_width * dev->tdm_slots;
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
next prev parent reply other threads:[~2026-11-09 7:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 11:29 [PATCH 0/5] Fix several issues in the DesignWare I2S driver phucduc.bui
2026-11-06 11:29 ` [PATCH 1/5] ASoC: dwc: Fix bit clock rate in TDM mode phucduc.bui
2026-11-09 7:10 ` Maxim Kochetkov [this message]
2026-11-06 11:29 ` [PATCH 2/5] ASoC: dwc: Fix error handling in dw_i2s_set_fmt() phucduc.bui
2026-11-09 7:19 ` Maxim Kochetkov
2026-11-06 11:29 ` [PATCH 3/5] ASoC: dwc: Fix channels_max derived from COMP_PARAM_1 phucduc.bui
2026-11-09 7:23 ` Maxim Kochetkov
2026-11-06 11:29 ` [PATCH 4/5] ASoC: dwc: Fix DMA fifo_size calculation phucduc.bui
2026-11-06 11:29 ` [PATCH 5/5] ASoC: dwc: Remove redundant error messages phucduc.bui
2026-11-08 14:05 ` Mark Brown
2026-11-09 2:59 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43d21ed-ff7e-40b8-93ff-42808985fac4@inbox.ru \
--to=fido_max@inbox.ru \
--cc=Andrew.Jackson@arm.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tim.bird@sony.com \
--cc=tiwai@suse.com \
--cc=xingyu.wu@starfivetech.com \
--cc=yuriz@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®