* [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon
@ 2024-05-06 12:46 Heiko Stuebner
2024-05-07 15:08 ` Conor Dooley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heiko Stuebner @ 2024-05-06 12:46 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt
Cc: heiko, andy.yan, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, quentin.schulz, Heiko Stuebner
From: Heiko Stuebner <heiko.stuebner@cherry.de>
RK3588 CSI and DSI support requires the GRF for DC-PHY.
Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
---
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
index 0b87c266760c6..0131c62893450 100644
--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
+++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
@@ -22,6 +22,7 @@ properties:
- rockchip,rk3568-usb2phy-grf
- rockchip,rk3588-bigcore0-grf
- rockchip,rk3588-bigcore1-grf
+ - rockchip,rk3588-dcphy-grf
- rockchip,rk3588-hdptxphy-grf
- rockchip,rk3588-ioc
- rockchip,rk3588-php-grf
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon
2024-05-06 12:46 [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon Heiko Stuebner
@ 2024-05-07 15:08 ` Conor Dooley
2024-05-07 16:48 ` Quentin Schulz
2024-10-27 20:30 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-05-07 15:08 UTC (permalink / raw)
To: Heiko Stuebner
Cc: robh, krzk+dt, conor+dt, andy.yan, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, quentin.schulz, Heiko Stuebner
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On Mon, May 06, 2024 at 02:46:32PM +0200, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon
2024-05-06 12:46 [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon Heiko Stuebner
2024-05-07 15:08 ` Conor Dooley
@ 2024-05-07 16:48 ` Quentin Schulz
2024-10-27 20:30 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Quentin Schulz @ 2024-05-07 16:48 UTC (permalink / raw)
To: Heiko Stuebner, robh, krzk+dt, conor+dt
Cc: andy.yan, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, Heiko Stuebner
Hi Heiko,
On 5/6/24 2:46 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 0b87c266760c6..0131c62893450 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -22,6 +22,7 @@ properties:
> - rockchip,rk3568-usb2phy-grf
> - rockchip,rk3588-bigcore0-grf
> - rockchip,rk3588-bigcore1-grf
> + - rockchip,rk3588-dcphy-grf
There are two. While the TRM states:
"""
There are two MIPICDPHY_GRF modules in RK3588.They have different base
address.
"""
(ignore the typo :) )
it states the same for the bigcore grf but we have two bindings for them
in there... So not sure what to go for here? Similarly, pipe-grf has
three instances but we define only one binding...
So who knows :)
That being said,
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon
2024-05-06 12:46 [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon Heiko Stuebner
2024-05-07 15:08 ` Conor Dooley
2024-05-07 16:48 ` Quentin Schulz
@ 2024-10-27 20:30 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2024-10-27 20:30 UTC (permalink / raw)
To: conor+dt, krzk+dt, Heiko Stuebner, robh
Cc: linux-kernel, quentin.schulz, Heiko Stuebner, andy.yan,
linux-rockchip, linux-arm-kernel, devicetree
On Mon, 6 May 2024 14:46:32 +0200, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> RK3588 CSI and DSI support requires the GRF for DC-PHY.
>
>
Applied, thanks!
[1/1] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon
commit: 22e027cc74488dba49f19f943c2da02726261f08
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-27 20:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-06 12:46 [PATCH] dt-bindings: soc: rockchip: add rk3588 mipi dcphy syscon Heiko Stuebner
2024-05-07 15:08 ` Conor Dooley
2024-05-07 16:48 ` Quentin Schulz
2024-10-27 20:30 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®