From: lyude@redhat.com
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
rust-for-linux@vger.kernel.org,
Danilo Krummrich <dakr@kernel.org>,
nouveau@lists.freedesktop.org, Miguel Ojeda <ojeda@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Alice Ryhl <aliceryhl@google.com>,
Shankari Anand <shankari.ak0208@gmail.com>,
David Airlie <airlied@gmail.com>,
Benno Lossin <lossin@kernel.org>,
Asahi Lina <lina+kernel@asahilina.net>
Subject: Re: [PATCH v5 2/4] rust/drm: Don't setup private driver data until registration
Date: Wed, 04 Feb 2026 15:56:54 -0500 [thread overview]
Message-ID: <f4504b830225a8fdb7407572d92b65daf390ac8a.camel@redhat.com> (raw)
In-Reply-To: <95623012-BAA8-4AA5-9D34-42FAE44B0FFD@collabora.com>
On Wed, 2026-02-04 at 15:28 -0300, Daniel Almeida wrote:
> > + pub(crate) data_is_init: AtomicBool,
>
> What about this?
>
> /**
> * @registered:
> *
> * Internally used by drm_dev_register() and
> drm_connector_register().
> */
> bool registered;
>
> Can’t we use this in lieu of this flag you’ve added?
No we couldn't unfortunately. As I said before: a lot of KMS setup has
to happen prior to registration, and most of those callbacks
(atomic_check, atomic_commit, etc.) can both happen before registration
and after. And that's a lot more difficult to deal with if we don't
have access to the private driver data for any of those callbacks.
So - it really does truly need to be tracked separately.
>
> > +
next prev parent reply other threads:[~2026-02-04 20:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 0:13 [PATCH v5 0/4] Introduce DeviceContext Lyude Paul
2026-01-31 0:13 ` [PATCH v5 1/4] rust/drm: " Lyude Paul
2026-02-06 13:28 ` Daniel Almeida
2026-02-12 23:39 ` Deborah Brouwer
2026-01-31 0:13 ` [PATCH v5 2/4] rust/drm: Don't setup private driver data until registration Lyude Paul
2026-02-04 18:28 ` Daniel Almeida
2026-02-04 20:56 ` lyude [this message]
2026-02-06 13:46 ` Daniel Almeida
2026-01-31 0:13 ` [PATCH v5 3/4] rust/drm/gem: Add DriverAllocImpl type alias Lyude Paul
2026-02-06 13:48 ` Daniel Almeida
2026-01-31 0:13 ` [PATCH v5 4/4] rust/drm/gem: Use DeviceContext with GEM objects Lyude Paul
2026-02-06 14:08 ` Daniel Almeida
2026-03-17 21:28 [PATCH v5 0/4] Introduce DeviceContext Lyude Paul
2026-03-17 21:28 ` [PATCH v5 2/4] rust/drm: Don't setup private driver data until registration Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4504b830225a8fdb7407572d92b65daf390ac8a.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lina+kernel@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=shankari.ak0208@gmail.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®