* [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms
@ 2026-04-03 10:09 Syed Saba Kareem
2026-04-03 11:55 ` Mark Brown
2026-04-03 15:33 ` Mario Limonciello
0 siblings, 2 replies; 5+ messages in thread
From: Syed Saba Kareem @ 2026-04-03 10:09 UTC (permalink / raw)
To: Mark Brown, alsa-devel
Cc: Vijendar Mukunda, Sunil-kumar Dommati, Syed Saba Kareem,
Mario Limonciello, Mark Pearson, Syed Saba Kareem,
Venkata Prasad Potturu, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Charles Keepax, Mario Limonciello (AMD),
Bard Liao, Krzysztof Kozlowski, Hasun Park, Simon Trimmer,
Kees Cook, open list:AMD ASoC DRIVERS, open list
Use DMI_MATCH instead of DMI_EXACT_MATCH for the Lenovo SKU,
So the quirk is applied to all variants of this model.
Fixes: 3acf517e1ae0 ("ASoC: amd: amd_sdw: add machine driver quirk for Lenovo models")
Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
---
sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
index 05484c72f9a8..986fefd0de08 100644
--- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
+++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
@@ -99,17 +99,17 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
.callback = soc_sdw_quirk_cb,
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
- DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YW"),
+ DMI_MATCH(DMI_PRODUCT_SKU, "21YW"),
},
- .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
+ .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | (ASOC_SDW_ACP_DMIC)),
},
{
.callback = soc_sdw_quirk_cb,
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
- DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YX"),
+ DMI_MATCH(DMI_PRODUCT_SKU, "21YX"),
},
- .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
+ .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | (ASOC_SDW_ACP_DMIC)),
},
{
.callback = soc_sdw_quirk_cb,
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms
2026-04-03 10:09 [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms Syed Saba Kareem
@ 2026-04-03 11:55 ` Mark Brown
2026-04-03 12:11 ` Mukunda,Vijendar
2026-04-03 15:33 ` Mario Limonciello
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2026-04-03 11:55 UTC (permalink / raw)
To: Syed Saba Kareem
Cc: alsa-devel, Vijendar Mukunda, Sunil-kumar Dommati,
Mario Limonciello, Mark Pearson, Venkata Prasad Potturu,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Charles Keepax,
Mario Limonciello (AMD),
Bard Liao, Krzysztof Kozlowski, Hasun Park, Simon Trimmer,
Kees Cook, open list:AMD ASoC DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
On Fri, Apr 03, 2026 at 03:39:38PM +0530, Syed Saba Kareem wrote:
> Use DMI_MATCH instead of DMI_EXACT_MATCH for the Lenovo SKU,
> So the quirk is applied to all variants of this model.
I only have patch 1 here, what's the story with the rest of the thread?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms
2026-04-03 11:55 ` Mark Brown
@ 2026-04-03 12:11 ` Mukunda,Vijendar
0 siblings, 0 replies; 5+ messages in thread
From: Mukunda,Vijendar @ 2026-04-03 12:11 UTC (permalink / raw)
To: Mark Brown, Syed Saba Kareem
Cc: alsa-devel, Sunil-kumar Dommati, Mario Limonciello, Mark Pearson,
Venkata Prasad Potturu, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Charles Keepax, Mario Limonciello (AMD),
Bard Liao, Krzysztof Kozlowski, Hasun Park, Simon Trimmer,
Kees Cook, open list:AMD ASoC DRIVERS, open list
On 03/04/26 17:25, Mark Brown wrote:
> On Fri, Apr 03, 2026 at 03:39:38PM +0530, Syed Saba Kareem wrote:
>> Use DMI_MATCH instead of DMI_EXACT_MATCH for the Lenovo SKU,
>> So the quirk is applied to all variants of this model.
> I only have patch 1 here, what's the story with the rest of the thread?
Kareem supposed to send single patch only. By mistake, he mentioned
PATCH 1/2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms
2026-04-03 10:09 [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms Syed Saba Kareem
2026-04-03 11:55 ` Mark Brown
@ 2026-04-03 15:33 ` Mario Limonciello
2026-04-06 5:22 ` Syed Saba Kareem
1 sibling, 1 reply; 5+ messages in thread
From: Mario Limonciello @ 2026-04-03 15:33 UTC (permalink / raw)
To: Syed Saba Kareem, Mark Brown, alsa-devel
Cc: Vijendar Mukunda, Sunil-kumar Dommati, Mark Pearson,
Venkata Prasad Potturu, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Charles Keepax, Mario Limonciello (AMD),
Bard Liao, Krzysztof Kozlowski, Hasun Park, Simon Trimmer,
Kees Cook, open list:AMD ASoC DRIVERS, open list
On 4/3/26 5:09 AM, Syed Saba Kareem wrote:
> Use DMI_MATCH instead of DMI_EXACT_MATCH for the Lenovo SKU,
> So the quirk is applied to all variants of this model.
This seems to do more than the patch description indicates as it also
adds the | (ASOC_SDW_ACP_DMIC).
Could you add that to the description?
>
> Fixes: 3acf517e1ae0 ("ASoC: amd: amd_sdw: add machine driver quirk for Lenovo models")
> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
> ---
> sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> index 05484c72f9a8..986fefd0de08 100644
> --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> @@ -99,17 +99,17 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
> .callback = soc_sdw_quirk_cb,
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> - DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YW"),
> + DMI_MATCH(DMI_PRODUCT_SKU, "21YW"),
> },
> - .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
> + .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | (ASOC_SDW_ACP_DMIC)),
> },
> {
> .callback = soc_sdw_quirk_cb,
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> - DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YX"),
> + DMI_MATCH(DMI_PRODUCT_SKU, "21YX"),
> },
> - .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
> + .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) | (ASOC_SDW_ACP_DMIC)),
> },
> {
> .callback = soc_sdw_quirk_cb,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms
2026-04-03 15:33 ` Mario Limonciello
@ 2026-04-06 5:22 ` Syed Saba Kareem
0 siblings, 0 replies; 5+ messages in thread
From: Syed Saba Kareem @ 2026-04-06 5:22 UTC (permalink / raw)
To: Mario Limonciello, Mark Brown, alsa-devel
Cc: Vijendar Mukunda, Sunil-kumar Dommati, Mark Pearson,
Venkata Prasad Potturu, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Charles Keepax, Mario Limonciello (AMD),
Bard Liao, Krzysztof Kozlowski, Hasun Park, Simon Trimmer,
Kees Cook, open list:AMD ASoC DRIVERS, open list
On 4/3/26 21:03, Mario Limonciello wrote:
> On 4/3/26 5:09 AM, Syed Saba Kareem wrote:
>> Use DMI_MATCH instead of DMI_EXACT_MATCH for the Lenovo SKU,
>> So the quirk is applied to all variants of this model.
>
> This seems to do more than the patch description indicates as it also
> adds the | (ASOC_SDW_ACP_DMIC).
>
> Could you add that to the description?
>
> Will send a fresh patch with updated commit description.
>>
>> Fixes: 3acf517e1ae0 ("ASoC: amd: amd_sdw: add machine driver quirk
>> for Lenovo models")
>> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
>> ---
>> sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> index 05484c72f9a8..986fefd0de08 100644
>> --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
>> @@ -99,17 +99,17 @@ static const struct dmi_system_id
>> soc_sdw_quirk_table[] = {
>> .callback = soc_sdw_quirk_cb,
>> .matches = {
>> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> - DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YW"),
>> + DMI_MATCH(DMI_PRODUCT_SKU, "21YW"),
>> },
>> - .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
>> + .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) |
>> (ASOC_SDW_ACP_DMIC)),
>> },
>> {
>> .callback = soc_sdw_quirk_cb,
>> .matches = {
>> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> - DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "21YX"),
>> + DMI_MATCH(DMI_PRODUCT_SKU, "21YX"),
>> },
>> - .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
>> + .driver_data = (void *)((ASOC_SDW_CODEC_SPKR) |
>> (ASOC_SDW_ACP_DMIC)),
>> },
>> {
>> .callback = soc_sdw_quirk_cb,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-06 5:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-03 10:09 [PATCH 1/2] ASoC : amd: acp: Update Quirk for Lenovo Platforms Syed Saba Kareem
2026-04-03 11:55 ` Mark Brown
2026-04-03 12:11 ` Mukunda,Vijendar
2026-04-03 15:33 ` Mario Limonciello
2026-04-06 5:22 ` Syed Saba Kareem
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®