* Re: [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path
2025-08-21 19:47 [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path Jihed Chaibi
@ 2025-08-22 7:01 ` Krzysztof Kozlowski
2025-11-02 20:12 ` Jihed Chaibi
2025-11-03 10:48 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 7:01 UTC (permalink / raw)
To: Jihed Chaibi, linus.walleij, brgl, aaro.koskinen, andreas,
khilman, rogerq, tony
Cc: krzk+dt, robh, conor+dt, peter.ujfalusi, lee, devicetree,
linux-gpio, linux-kernel, shuah, Krzysztof Kozlowski
On 21/08/2025 21:47, Jihed Chaibi wrote:
> The $id for a binding should match its file path. The ti,twl4030-gpio
> binding is located in the gpio/ subdirectory but was missing this from
> its $id.
>
> Correct the path to follow the standard convention.
>
> Fixes: 842dcff8e2d6 ("dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema")
>
Don't add blank lines between tags.
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
>
> ---
> Changes in v5:
> - No changes, only added 'Fixes' tag.
Don't resend for that.
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.
Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path
2025-08-21 19:47 [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path Jihed Chaibi
2025-08-22 7:01 ` Krzysztof Kozlowski
@ 2025-11-02 20:12 ` Jihed Chaibi
2025-11-03 10:48 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Jihed Chaibi @ 2025-11-02 20:12 UTC (permalink / raw)
To: linus.walleij, brgl
Cc: krzk+dt, robh, conor+dt, peter.ujfalusi, lee, devicetree,
linux-gpio, linux-kernel, shuah, Krzysztof Kozlowski,
aaro.koskinen, Andreas Kemnade, khilman, rogerq, Tony Lindgren
On Thu, Aug 21, 2025 at 9:47 PM Jihed Chaibi <jihed.chaibi.dev@gmail.com> wrote:
>
> The $id for a binding should match its file path. The ti,twl4030-gpio
> binding is located in the gpio/ subdirectory but was missing this from
> its $id.
>
> Correct the path to follow the standard convention.
>
> Fixes: 842dcff8e2d6 ("dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema")
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
>
> ---
> Changes in v5:
> - No changes, only added 'Fixes' tag.
>
> Changes in v4:
> - No changes.
> - This patch is split from larger series per maintainer feedback.
> - v3 link:
> https://lore.kernel.org/all/20250816021523.167049-1-jihed.chaibi.dev@gmail.com/
>
> Changes in v3:
> - This patch was added to the patch series in v3.
> ---
> Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml b/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
> index 5e3e199fd..96d50d14c 100644
> --- a/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/ti,twl4030-gpio.yaml#
> +$id: http://devicetree.org/schemas/gpio/ti,twl4030-gpio.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: TI TWL4030 GPIO controller
> --
> 2.39.5
>
Hi Bartosz, Linus,
Gentle ping on this fix,
It was reviewed by Krzysztof a couple of months ago. I wonder if it's
ready to be picked up.
Cheers,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path
2025-08-21 19:47 [PATCH v5] dt-bindings: gpio: ti,twl4030: Correct the schema $id path Jihed Chaibi
2025-08-22 7:01 ` Krzysztof Kozlowski
2025-11-02 20:12 ` Jihed Chaibi
@ 2025-11-03 10:48 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2025-11-03 10:48 UTC (permalink / raw)
To: linus.walleij, brgl, aaro.koskinen, andreas, khilman, rogerq,
tony, Jihed Chaibi
Cc: Bartosz Golaszewski, krzk+dt, robh, conor+dt, peter.ujfalusi,
lee, devicetree, linux-gpio, linux-kernel, shuah,
Krzysztof Kozlowski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Thu, 21 Aug 2025 21:47:10 +0200, Jihed Chaibi wrote:
> The $id for a binding should match its file path. The ti,twl4030-gpio
> binding is located in the gpio/ subdirectory but was missing this from
> its $id.
>
> Correct the path to follow the standard convention.
>
> Fixes: 842dcff8e2d6 ("dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema")
>
> [...]
Applied, thanks!
[1/1] dt-bindings: gpio: ti,twl4030: Correct the schema $id path
https://git.kernel.org/brgl/linux/c/4a372798e12cc777918db90c06e11c80e90bd001
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread