mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sergey Ryazanov <ryazanov.s.a@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Deepak Kumar Singh <deepak.singh@oss.qualcomm.com>
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: qcom,bam-dmux: Add memory-region and qcom,vmid properties
Date: Thu, 1 Oct 2026 11:28:22 +0530	[thread overview]
Message-ID: <f4a2c926-8cf9-4d76-ac42-98d9f225be93@oss.qualcomm.com> (raw)
In-Reply-To: <CAFEp6-0juFLDxo6kCTf_RrHv0EAevVqB3DP47=fg6PBNSCDcbA@mail.gmail.com>

Hi Loic, Krzysztof,

On 21-09-2026 01:46 pm, Loic Poulain wrote:
> Hi Krzysztof,
>
> On Sun, Sep 20, 2026 at 12:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Sun, Sep 20, 2026 at 08:32:29AM +0530, Vishnu Santhosh wrote:
>>> Some Qualcomm SoCs, such as Shikra, run the modem in a separate security
>>> domain with restricted access to system memory. BAM-DMUX DMA mappings
>> Then this is specific to Shikra and should come with its compatible plus
>> constraints per variant.
>>
>>> must therefore be constrained to a designated region that can be shared
>>> with the modem.
>>>
>>> Add an optional memory-region property to reference a restricted DMA
>>> pool used for BAM-DMUX mappings, and a qcom,vmid property to identify the
>>> remote execution environment that is granted access to the pool through
>>> SCM.
>>>
>>> Require memory-region whenever qcom,vmid is specified.
>>>
>>> Co-developed-by: Deepak Kumar Singh <deepak.singh@oss.qualcomm.com>
>>> Signed-off-by: Deepak Kumar Singh <deepak.singh@oss.qualcomm.com>
>>> Signed-off-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
>>> ---
>>>   .../devicetree/bindings/net/qcom,bam-dmux.yaml     | 38 ++++++++++++++++++++++
>>>   1 file changed, 38 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
>>> index 33746c238513d72366bc52359fb10f275475b331..5351269b0ab72ede808ae47b55d57580af209038 100644
>>> --- a/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
>>> +++ b/Documentation/devicetree/bindings/net/qcom,bam-dmux.yaml
>>> @@ -72,6 +72,24 @@ properties:
>>>         - const: tx
>>>         - const: rx
>>>
>>> +  memory-region:
>>> +    maxItems: 1
>>> +    description:
>>> +      Phandle to a reserved-memory node compatible with restricted-dma-pool.
>>> +      The BAM-DMUX device uses the pool for DMA mappings.
>>> +
>>> +  qcom,vmid:
> I can see several existing drivers, along with a few ongoing series,
> using this same property. Instead of redefining it in every binding,
> should we consider defining the prop/type once in a common soc/qcom
> schema and reusing it across bindings?

The existing users currently differ (rmtfs: qcom,vmid, 1-2 items;
fastrpc: qcom,vmids, unconstrained), so consolidating them needs a
separate discussion with involved module owners.

Krzysztof, do you want this consolidated into a common schema? If yes,
can this series keep the local definition, with the consolidation
handled as a separate change?


Thanks,
Vishnu

>
>>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>>> +    minItems: 1
>> Drop
>>
>>> +    maxItems: 1
>>> +    items:
>>> +      minimum: 1
>>> +      maximum: 63
>>> +    description:
>>> +      VMID of the remote execution environment that is granted access to the
>>> +      restricted DMA pool through SCM. The local execution environment is
>>> +      retained automatically and must not be specified.
>>> +
>>>   required:
>>>     - compatible
>>>     - interrupts
>>> @@ -81,12 +99,29 @@ required:
>>>     - dmas
>>>     - dma-names
>>>
>>> +dependencies:
>>> +  qcom,vmid: [ memory-region ]
>>> +
>>>   additionalProperties: false
>>>
>>>   examples:
>>>     - |
>>> +    #include <dt-bindings/firmware/qcom,scm.h>
>>>       #include <dt-bindings/interrupt-controller/irq.h>
>>>
>>> +    reserved-memory {
>>> +        #address-cells = <1>;
>>> +        #size-cells = <1>;
>>> +        ranges;
>>> +
>>> +        bam_dmux_pool: restricted-dma-pool {
>>> +            compatible = "restricted-dma-pool";
>>> +            size = <0x40000>;
>>> +            alignment = <0x40000>;
>>> +            alloc-ranges = <0x80000000 0x80000000>;
>>> +        };
>>> +    };
>> This wasn't here before. Drop.
>>
>> Best regards,
>> Krzysztof
>>

  reply	other threads:[~2026-10-01  5:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20  3:02 [PATCH net-next v2 0/2] net: wwan: qcom_bam_dmux: Add restricted DMA pool support Vishnu Santhosh
2026-09-20  3:02 ` [PATCH net-next v2 1/2] dt-bindings: net: qcom,bam-dmux: Add memory-region and qcom,vmid properties Vishnu Santhosh
2026-09-20 10:36   ` Krzysztof Kozlowski
2026-09-21  8:16     ` Loic Poulain
2026-10-01  5:58       ` Vishnu Santhosh [this message]
2026-09-21 11:04     ` Vishnu Santhosh
2026-09-21  3:48   ` netdev-bot+sashiko
2026-10-01 15:41     ` Vishnu Santhosh
2026-09-20  3:02 ` [PATCH net-next v2 2/2] net: wwan: qcom_bam_dmux: Assign restricted DMA pool to remote processor Vishnu Santhosh
2026-09-21  3:48   ` netdev-bot+sashiko
2026-10-01 15:35     ` Vishnu Santhosh
2026-09-21  7:59   ` Loic Poulain
2026-09-21 11:13     ` Vishnu Santhosh
2026-09-28 10:32 ` [PATCH net-next v2 0/2] net: wwan: qcom_bam_dmux: Add restricted DMA pool support Vishnu Santhosh
2026-09-29  8:14   ` Stephan Gerhold
2026-09-29 14:58     ` Vishnu Santhosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4a2c926-8cf9-4d76-ac42-98d9f225be93@oss.qualcomm.com \
    --to=vishnu.santhosh@oss.qualcomm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=deepak.singh@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=ryazanov.s.a@gmail.com \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®