From: Jason Yan <yanaijie@huawei.com>
To: Xingui Yang <yangxingui@huawei.com>, <john.g.garry@oracle.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<damien.lemoal@opensource.wdc.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <prime.zeng@hisilicon.com>,
<chenxiang66@hisilicon.com>, <kangfenglong@huawei.com>
Subject: Re: [PATCH v2] scsi: libsas: Fix disk not being scanned in after being removed
Date: Tue, 5 Mar 2024 11:00:45 +0800 [thread overview]
Message-ID: <f52b3c8c-886e-665d-a50d-cba3387d8418@huawei.com> (raw)
In-Reply-To: <20240227090149.29039-1-yangxingui@huawei.com>
On 2024/2/27 17:01, Xingui Yang wrote:
> As of commit d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to
> update PHY info"), do discovery will send a new SMP_DISCOVER and update
> phy->phy_change_count. We found that if the disk is reconnected and phy
> change_count changes at this time, the disk scanning process will not be
> triggered.
>
> So update the PHY info with the last query results.
>
> Fixes: d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to update PHY info")
> Signed-off-by: Xingui Yang<yangxingui@huawei.com>
> ---
> v1 -> v2:
> Use sas_get_phy_discover() instead of sas_get_phy_attached_dev() in
> sas_rediscover_dev() and use disc_resp to update phy info.
> ---
> drivers/scsi/libsas/sas_expander.c | 37 ++++++++++++++++++++++--------
> 1 file changed, 28 insertions(+), 9 deletions(-)
Looks good to me:
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2024-03-05 3:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 9:01 Xingui Yang
2024-03-05 3:00 ` Jason Yan [this message]
2024-03-06 18:43 ` John Garry
2024-03-07 2:13 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f52b3c8c-886e-665d-a50d-cba3387d8418@huawei.com \
--to=yanaijie@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@hisilicon.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®