[PATCH] dt-bindings: PCI: rcar-gen4-pci-host: Replace sft_ce IRQ with AER IRQ on R-Car Gen5

[PATCH] dt-bindings: PCI: rcar-gen4-pci-host: Replace sft_ce IRQ with AER IRQ on R-Car Gen5

[Marek Vasut]

The R-Car Gen5 SoC PCIe4 controller does not have dedicated sft_ce IRQ.
Make that interrupt conditionally available only on R-Car Gen4 SoC PCIe
controller.

The R-Car Gen5 SoC PCIe4 controller does have dedicated AER interrupt,
include it from the beginning. R-Car Gen4 SoC PCIe controller also has
an AER interrupt, but to retain binding backward compatibility, this
interrupt is kept optional and added in a separate patchset.

Fixes: 5b555a496160 ("dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible")
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Koichiro Den <den@valinux.co.jp>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
NOTE: Gen4 AER is added in https://lore.kernel.org/all/20260928165230.3397664-1-den@valinux.co.jp/
---
 .../bindings/pci/rcar-gen4-pci-host.yaml      | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
index 362c43a1a15d0..083b77d4de8f7 100644
--- a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
@@ -28,13 +28,6 @@ properties:
   interrupts:
     maxItems: 4
 
-  interrupt-names:
-    items:
-      - const: msi
-      - const: dma
-      - const: sft_ce
-      - const: app
-
   clocks:
     maxItems: 2
 
@@ -98,6 +91,13 @@ allOf:
             - const: app
             - const: phy
             - const: config
+
+        interrupt-names:
+          items:
+            - const: msi
+            - const: dma
+            - const: sft_ce
+            - const: app
   - if:
       properties:
         compatible:
@@ -117,6 +117,13 @@ allOf:
             - const: app
             - const: config
 
+        interrupt-names:
+          items:
+            - const: msi
+            - const: dma
+            - const: app
+            - const: aer
+
 unevaluatedProperties: false
 
 examples:
-- 
2.53.0

Re: [PATCH] dt-bindings: PCI: rcar-gen4-pci-host: Replace sft_ce IRQ with AER IRQ on R-Car Gen5

[Marek Vasut]

On 10/3/26 11:57 PM, Marek Vasut wrote:
> The R-Car Gen5 SoC PCIe4 controller does not have dedicated sft_ce IRQ.
> Make that interrupt conditionally available only on R-Car Gen4 SoC PCIe
> controller.
> 
> The R-Car Gen5 SoC PCIe4 controller does have dedicated AER interrupt,
> include it from the beginning. R-Car Gen4 SoC PCIe controller also has
> an AER interrupt, but to retain binding backward compatibility, this
> interrupt is kept optional and added in a separate patchset.
> 
> Fixes: 5b555a496160 ("dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Koichiro Den <den@valinux.co.jp>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> NOTE: Gen4 AER is added in https://lore.kernel.org/all/20260928165230.3397664-1-den@valinux.co.jp/

This would be good to apply since it is a fix, however, I think this 
needs review from DT maintainers first.

Thank you for your help!

> ---
>   .../bindings/pci/rcar-gen4-pci-host.yaml      | 21 ++++++++++++-------
>   1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> index 362c43a1a15d0..083b77d4de8f7 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> @@ -28,13 +28,6 @@ properties:
>     interrupts:
>       maxItems: 4
>   
> -  interrupt-names:
> -    items:
> -      - const: msi
> -      - const: dma
> -      - const: sft_ce
> -      - const: app
> -
>     clocks:
>       maxItems: 2
>   
> @@ -98,6 +91,13 @@ allOf:
>               - const: app
>               - const: phy
>               - const: config
> +
> +        interrupt-names:
> +          items:
> +            - const: msi
> +            - const: dma
> +            - const: sft_ce
> +            - const: app
>     - if:
>         properties:
>           compatible:
> @@ -117,6 +117,13 @@ allOf:
>               - const: app
>               - const: config
>   
> +        interrupt-names:
> +          items:
> +            - const: msi
> +            - const: dma
> +            - const: app
> +            - const: aer
> +
>   unevaluatedProperties: false
>   
>   examples:


-- 
Best regards,
Marek Vasut