mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Chanh Nguyen" <chanh@os.amperecomputing.com>,
	"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Joel Stanley" <joel@jms.id.au>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: dts: aspeed: mtmitchell: Add MCTP
Date: Thu, 27 Apr 2023 10:34:43 +0930	[thread overview]
Message-ID: <f5c261ff-7901-434a-aa2f-3b2f684cb4a7@app.fastmail.com> (raw)
In-Reply-To: <20230425065715.21871-5-chanh@os.amperecomputing.com>



On Tue, 25 Apr 2023, at 16:27, Chanh Nguyen wrote:
> Enable MCTP driver on I2C3 bus for MCTP transaction
>
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts 
> b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> index 0b5ea8620063..33e06eafed31 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> @@ -366,6 +366,13 @@
> 
>  &i2c3 {
>  	status = "okay";
> +	bus-frequency = <1000000>;
> +	multi-master;
> +	mctp-controller;
> +	mctp@10 {
> +		compatible = "mctp-i2c-controller";
> +		reg = <0x10>;

This needs to be `reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;`

Andrew

  reply	other threads:[~2023-04-27  1:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  6:57 [PATCH 0/4] Update the device tree for Ampere's Mt.Mitchell BMC Chanh Nguyen
2023-04-25  6:57 ` [PATCH 1/4] ARM: dts: aspeed: mtmitchell: Enable the BMC UART8 and UART9 Chanh Nguyen
2023-04-25  6:57 ` [PATCH 2/4] ARM: dts: aspeed: mtmitchell: Add I2C Fan Chanh Nguyen
2023-04-25 13:15   ` Krzysztof Kozlowski
2023-05-07  8:20     ` Chanh Nguyen
2023-05-07  8:23       ` Krzysztof Kozlowski
2023-05-07  9:39         ` Chanh Nguyen
2023-04-25  6:57 ` [PATCH 3/4] ARM: dts: aspeed: mtmitchell: Update ADC sensors for Mt.Mitchell DVT systems Chanh Nguyen
2023-04-25  6:57 ` [PATCH 4/4] ARM: dts: aspeed: mtmitchell: Add MCTP Chanh Nguyen
2023-04-27  1:04   ` Andrew Jeffery [this message]
2023-05-07  8:31     ` Chanh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5c261ff-7901-434a-aa2f-3b2f684cb4a7@app.fastmail.com \
    --to=andrew@aj.id.au \
    --cc=chanh@os.amperecomputing.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®