From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanh Nguyen <chanh@os.amperecomputing.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: aspeed: mtmitchell: Add I2C Fan
Date: Tue, 25 Apr 2023 15:15:08 +0200 [thread overview]
Message-ID: <7ee3eec8-b5b4-2591-adcd-1831bf7de02b@linaro.org> (raw)
In-Reply-To: <20230425065715.21871-3-chanh@os.amperecomputing.com>
On 25/04/2023 08:57, Chanh Nguyen wrote:
> Add the MAX31790 node as a Fan I2C controller. It controls the
> TACH and PWM for Fan Mt.Mitchell system.
>
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> index e79f56208b89..6455cf80da0e 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> @@ -477,6 +477,18 @@
> line-name = "bmc-ocp0-en-n";
> };
> };
> +
> + max31790@20 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "maxim,max31790";
Unfortunately the compatible is undocumented.
Please run scripts/checkpatch.pl and fix reported warnings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-25 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 6:57 [PATCH 0/4] Update the device tree for Ampere's Mt.Mitchell BMC Chanh Nguyen
2023-04-25 6:57 ` [PATCH 1/4] ARM: dts: aspeed: mtmitchell: Enable the BMC UART8 and UART9 Chanh Nguyen
2023-04-25 6:57 ` [PATCH 2/4] ARM: dts: aspeed: mtmitchell: Add I2C Fan Chanh Nguyen
2023-04-25 13:15 ` Krzysztof Kozlowski [this message]
2023-05-07 8:20 ` Chanh Nguyen
2023-05-07 8:23 ` Krzysztof Kozlowski
2023-05-07 9:39 ` Chanh Nguyen
2023-04-25 6:57 ` [PATCH 3/4] ARM: dts: aspeed: mtmitchell: Update ADC sensors for Mt.Mitchell DVT systems Chanh Nguyen
2023-04-25 6:57 ` [PATCH 4/4] ARM: dts: aspeed: mtmitchell: Add MCTP Chanh Nguyen
2023-04-27 1:04 ` Andrew Jeffery
2023-05-07 8:31 ` Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee3eec8-b5b4-2591-adcd-1831bf7de02b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@aj.id.au \
--cc=chanh@os.amperecomputing.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®