From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alex Elder <elder@linaro.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
andersson@kernel.org, agross@kernel.org
Cc: quic_rohiagar@quicinc.com, caleb.connolly@linaro.org,
mka@chromium.org, evgreen@chromium.org,
quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
elder@kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: qcom: sdx65: add IPA information
Date: Sat, 25 Mar 2023 13:12:17 +0100 [thread overview]
Message-ID: <f600869e-0fd8-ca19-1baf-d23f7a9103d6@linaro.org> (raw)
In-Reply-To: <98fcbdd4-77b3-5b17-7102-c590f1a5a63e@kernel.org>
On 25.03.2023 12:14, Krzysztof Kozlowski wrote:
> On 24/03/2023 21:15, Alex Elder wrote:
>> Add IPA-related nodes and definitions to "sdx65.dtsi". The SMP2P
>> nodes (ipa_smp2p_out and ipa_smp2p_in) are already present.
>>
>> Enable IPA in "sdx65-mtp.dts"; this GSI firmware is loaded by Trust
>> Zone on this platform.
>>
>> Tested-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> Signed-off-by: Alex Elder <elder@linaro.org>
>> ---
>> arch/arm/boot/dts/qcom-sdx65-mtp.dts | 5 ++++
>> arch/arm/boot/dts/qcom-sdx65.dtsi | 38 ++++++++++++++++++++++++++++
>> 2 files changed, 43 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
>> index ed98c83c141fc..72e25de0db5fc 100644
>> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
>> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
>> @@ -245,6 +245,11 @@ &blsp1_uart3 {
>> status = "okay";
>> };
>>
>> +&ipa {
>> + qcom,gsi-loader = "skip";
>> + status = "okay";
>> +};
>> +
>> &qpic_bam {
>> status = "okay";
>> };
>> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
>> index 192f9f94bc8b4..360d6dc144811 100644
>> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
>> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
>> @@ -11,6 +11,7 @@
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/power/qcom-rpmpd.h>
>> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> +#include <dt-bindings/interconnect/qcom,sdx65.h>
>>
>> / {
>> #address-cells = <1>;
>> @@ -299,6 +300,43 @@ tcsr_mutex: hwlock@1f40000 {
>> #hwlock-cells = <1>;
>> };
>>
>> + ipa: ipa@3e04000 {
>> + compatible = "qcom,sdx65-ipa";
>> +
>> + iommus = <&apps_smmu 0x5e0 0x0>,
>> + <&apps_smmu 0x5e2 0x0>;
>> + reg = <0x3f40000 0x10000>,
>> + <0x3f50000 0x5000>,
>> + <0x3e04000 0xfc000>;
>> + reg-names = "ipa-reg",
>> + "ipa-shared",
>> + "gsi";
>> +
>> + interrupts-extended = <&intc GIC_SPI 241 IRQ_TYPE_EDGE_RISING>,
>> + <&intc GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
>> + <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
>> + <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-names = "ipa",
>> + "gsi",
>> + "ipa-clock-query",
>> + "ipa-setup-ready";
>
> These look misaligned.
>
> With above:
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
With this and moving iommus below interconnect:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-25 12:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 20:15 [PATCH 0/2] ARM: dts: qcom: sdx65: support IPA Alex Elder
2023-03-24 20:15 ` [PATCH 1/2] ARM: dts: qcom: sdx65: add IPA information Alex Elder
2023-03-25 11:14 ` Krzysztof Kozlowski
2023-03-25 12:12 ` Konrad Dybcio [this message]
2023-03-26 16:04 ` Alex Elder
2023-03-27 8:57 ` Konrad Dybcio
2023-03-27 12:24 ` Alex Elder
2023-03-26 16:01 ` Alex Elder
2023-03-26 16:04 ` Krzysztof Kozlowski
2023-03-26 16:08 ` Alex Elder
2023-03-24 20:15 ` [PATCH 2/2] ARM: dts: qcom-sdx65: move status properties to end of nodes Alex Elder
2023-03-25 12:12 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f600869e-0fd8-ca19-1baf-d23f7a9103d6@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_avuyyuru@quicinc.com \
--cc=quic_cpratapa@quicinc.com \
--cc=quic_jponduru@quicinc.com \
--cc=quic_rohiagar@quicinc.com \
--cc=quic_subashab@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®