mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] iommu: Remove iommu_sva_unbind_gpasid
@ 2024-06-28 11:30 Mark-PK Tsai
  2024-06-28 12:33 ` Baolu Lu
  2024-07-02  5:42 ` AngeloGioacchino Del Regno
  0 siblings, 2 replies; 3+ messages in thread
From: Mark-PK Tsai @ 2024-06-28 11:30 UTC (permalink / raw)
  To: Joerg Roedel, Will Deacon, Robin Murphy, Matthias Brugger,
	AngeloGioacchino Del Regno
  Cc: yj.chiang, Mark-PK Tsai, iommu, linux-kernel, linux-arm-kernel,
	linux-mediatek

This is a left over of commit 0c9f17877891
("iommu: Remove guest pasid related interfaces and definitions")

Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
 include/linux/iommu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index 17b3f36ad843..225403cfe614 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -785,8 +785,6 @@ extern int iommu_attach_device(struct iommu_domain *domain,
 			       struct device *dev);
 extern void iommu_detach_device(struct iommu_domain *domain,
 				struct device *dev);
-extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain,
-				   struct device *dev, ioasid_t pasid);
 extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);
 extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);
 extern int iommu_map(struct iommu_domain *domain, unsigned long iova,
-- 
2.18.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu: Remove iommu_sva_unbind_gpasid
  2024-06-28 11:30 [PATCH] iommu: Remove iommu_sva_unbind_gpasid Mark-PK Tsai
@ 2024-06-28 12:33 ` Baolu Lu
  2024-07-02  5:42 ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 3+ messages in thread
From: Baolu Lu @ 2024-06-28 12:33 UTC (permalink / raw)
  To: Mark-PK Tsai, Joerg Roedel, Will Deacon, Robin Murphy,
	Matthias Brugger, AngeloGioacchino Del Regno
  Cc: baolu.lu, yj.chiang, iommu, linux-kernel, linux-arm-kernel,
	linux-mediatek

On 2024/6/28 19:30, Mark-PK Tsai wrote:
> This is a left over of commit 0c9f17877891
> ("iommu: Remove guest pasid related interfaces and definitions")
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
>   include/linux/iommu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 17b3f36ad843..225403cfe614 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -785,8 +785,6 @@ extern int iommu_attach_device(struct iommu_domain *domain,
>   			       struct device *dev);
>   extern void iommu_detach_device(struct iommu_domain *domain,
>   				struct device *dev);
> -extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain,
> -				   struct device *dev, ioasid_t pasid);

Not sure why this still remains there. But it seems not alone.

$ git grep iommu_sva_unbind_gpasid
Documentation/userspace-api/iommu.rst:  int 
iommu_sva_unbind_gpasid(struct iommu_domain *domain,
include/linux/iommu.h:extern int iommu_sva_unbind_gpasid(struct 
iommu_domain *domain,

I believe the document should also be removed.

>   extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);
>   extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);
>   extern int iommu_map(struct iommu_domain *domain, unsigned long iova,

Best regards,
baolu

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu: Remove iommu_sva_unbind_gpasid
  2024-06-28 11:30 [PATCH] iommu: Remove iommu_sva_unbind_gpasid Mark-PK Tsai
  2024-06-28 12:33 ` Baolu Lu
@ 2024-07-02  5:42 ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-07-02  5:42 UTC (permalink / raw)
  To: Mark-PK Tsai, Joerg Roedel, Will Deacon, Robin Murphy, Matthias Brugger
  Cc: yj.chiang, iommu, linux-kernel, linux-arm-kernel, linux-mediatek

Il 28/06/24 13:30, Mark-PK Tsai ha scritto:
> This is a left over of commit 0c9f17877891
> ("iommu: Remove guest pasid related interfaces and definitions")
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>

Please also fix the documentation, after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   include/linux/iommu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 17b3f36ad843..225403cfe614 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -785,8 +785,6 @@ extern int iommu_attach_device(struct iommu_domain *domain,
>   			       struct device *dev);
>   extern void iommu_detach_device(struct iommu_domain *domain,
>   				struct device *dev);
> -extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain,
> -				   struct device *dev, ioasid_t pasid);
>   extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);
>   extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);
>   extern int iommu_map(struct iommu_domain *domain, unsigned long iova,



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-02  5:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-28 11:30 [PATCH] iommu: Remove iommu_sva_unbind_gpasid Mark-PK Tsai
2024-06-28 12:33 ` Baolu Lu
2024-07-02  5:42 ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®