* [PATCH] clocksource/drivers/oxnas: fix error check return value of irq_of_parse_and_map()
@ 2022-04-22 8:48 cgel.zte
2022-04-22 16:22 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-22 8:48 UTC (permalink / raw)
To: daniel.lezcano, tglx
Cc: narmstrong, linux-kernel, linux-arm-kernel, linux-oxnas, Lv Ruyi,
Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
The irq_of_parse_and_map() function returns 0 on failure, and does not
return an negative value.
Fixes: 89355274e1f7 ("clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/clocksource/timer-oxnas-rps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-oxnas-rps.c b/drivers/clocksource/timer-oxnas-rps.c
index 56c0cc32d0ac..d514b44e67dd 100644
--- a/drivers/clocksource/timer-oxnas-rps.c
+++ b/drivers/clocksource/timer-oxnas-rps.c
@@ -236,7 +236,7 @@ static int __init oxnas_rps_timer_init(struct device_node *np)
}
rps->irq = irq_of_parse_and_map(np, 0);
- if (rps->irq < 0) {
+ if (!rps->irq) {
ret = -EINVAL;
goto err_iomap;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] clocksource/drivers/oxnas: fix error check return value of irq_of_parse_and_map()
2022-04-22 8:48 [PATCH] clocksource/drivers/oxnas: fix error check return value of irq_of_parse_and_map() cgel.zte
@ 2022-04-22 16:22 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2022-04-22 16:22 UTC (permalink / raw)
To: cgel.zte, daniel.lezcano, tglx
Cc: linux-kernel, linux-arm-kernel, linux-oxnas, Lv Ruyi, Zeal Robot
On 22/04/2022 10:48, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return an negative value.
>
> Fixes: 89355274e1f7 ("clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/clocksource/timer-oxnas-rps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-oxnas-rps.c b/drivers/clocksource/timer-oxnas-rps.c
> index 56c0cc32d0ac..d514b44e67dd 100644
> --- a/drivers/clocksource/timer-oxnas-rps.c
> +++ b/drivers/clocksource/timer-oxnas-rps.c
> @@ -236,7 +236,7 @@ static int __init oxnas_rps_timer_init(struct device_node *np)
> }
>
> rps->irq = irq_of_parse_and_map(np, 0);
> - if (rps->irq < 0) {
> + if (!rps->irq) {
> ret = -EINVAL;
> goto err_iomap;
> }
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-22 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 8:48 [PATCH] clocksource/drivers/oxnas: fix error check return value of irq_of_parse_and_map() cgel.zte
2022-04-22 16:22 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®