From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: apopple@linux.ibm.com, mikey@neuling.org, peterz@infradead.org,
oleg@redhat.com, npiggin@gmail.com, linux-kernel@vger.kernel.org,
paulus@samba.org, jolsa@kernel.org, fweisbec@gmail.com,
naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
mingo@kernel.org
Subject: Re: [PATCH v2 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint
Date: Wed, 1 Apr 2020 11:44:11 +0200 [thread overview]
Message-ID: <f6a3ac3b-41c8-8a18-0f3d-ea4d4ef04db1@c-s.fr> (raw)
In-Reply-To: <d62efd40-4aa6-01e5-a669-3590b121c0f8@c-s.fr>
Le 01/04/2020 à 11:11, Christophe Leroy a écrit :
>
>
> Le 01/04/2020 à 10:57, Ravi Bangoria a écrit :
>>
>>
>> On 4/1/20 12:33 PM, Christophe Leroy wrote:
>>>
>>>
>>> Le 01/04/2020 à 08:12, Ravi Bangoria a écrit :
>>>> Introduce new parameter 'nr' to __set_breakpoint() which indicates
>>>> which DAWR should be programed. Also convert current_brk variable
>>>> to an array.
>>>>
>>>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
>>>> ---
>>>> arch/powerpc/include/asm/debug.h | 2 +-
>>>> arch/powerpc/include/asm/hw_breakpoint.h | 2 +-
>>>> arch/powerpc/kernel/hw_breakpoint.c | 8 ++++----
>>>> arch/powerpc/kernel/process.c | 14 +++++++-------
>>>> arch/powerpc/kernel/signal.c | 2 +-
>>>> arch/powerpc/xmon/xmon.c | 2 +-
>>>> 6 files changed, 15 insertions(+), 15 deletions(-)
>>>>
>>>> diff --git a/arch/powerpc/include/asm/debug.h
>>>> b/arch/powerpc/include/asm/debug.h
>>>> index 7756026b95ca..6228935a8b64 100644
>>>> --- a/arch/powerpc/include/asm/debug.h
>>>> +++ b/arch/powerpc/include/asm/debug.h
>>>> @@ -45,7 +45,7 @@ static inline int debugger_break_match(struct
>>>> pt_regs *regs) { return 0; }
>>>> static inline int debugger_fault_handler(struct pt_regs *regs) {
>>>> return 0; }
>>>> #endif
>>>> -void __set_breakpoint(struct arch_hw_breakpoint *brk);
>>>> +void __set_breakpoint(struct arch_hw_breakpoint *brk, int nr);
>>>
>>> Same, I think it would make more sense to have nr as first argument.
>>
>> Sorry, didn't get your point. How will that help?
>>
>
> Well, it is a tiny detail but for me it is more natural to first tel
> which element you modify before telling how you modify it.
>
And the second advantage is that when you have a function
get_something() paired with you set_something(), you can then have it as
first argument in both functions.
void set_something(int nr, type something)
type get_something(int nr)
But again, that's detail, so up to you.
Christophe
next prev parent reply other threads:[~2020-04-01 9:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 6:12 [PATCH v2 00/16] powerpc/watchpoint: Preparation for more than one watchpoint Ravi Bangoria
2020-04-01 6:12 ` [PATCH v2 01/16] powerpc/watchpoint: Rename current DAWR macros Ravi Bangoria
2020-04-01 6:12 ` [PATCH v2 02/16] powerpc/watchpoint: Add SPRN macros for second DAWR Ravi Bangoria
2020-04-01 6:12 ` [PATCH v2 03/16] powerpc/watchpoint: Introduce function to get nr watchpoints dynamically Ravi Bangoria
2020-04-01 6:29 ` Christophe Leroy
2020-04-01 6:50 ` Ravi Bangoria
2020-04-01 7:05 ` Christophe Leroy
2020-04-01 6:12 ` [PATCH v2 04/16] powerpc/watchpoint/ptrace: Return actual num of available watchpoints Ravi Bangoria
2020-04-01 6:12 ` [PATCH v2 05/16] powerpc/watchpoint: Provide DAWR number to set_dawr Ravi Bangoria
2020-04-01 7:03 ` Christophe Leroy
2020-04-01 6:12 ` [PATCH v2 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint Ravi Bangoria
2020-04-01 7:03 ` Christophe Leroy
2020-04-01 8:57 ` Ravi Bangoria
2020-04-01 9:11 ` Christophe Leroy
2020-04-01 9:44 ` Christophe Leroy [this message]
2020-04-01 6:13 ` [PATCH v2 07/16] powerpc/watchpoint: Get watchpoint count dynamically while disabling them Ravi Bangoria
2020-04-01 6:32 ` Christophe Leroy
2020-04-01 9:19 ` Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Ravi Bangoria
2020-04-01 6:33 ` Christophe Leroy
2020-04-01 9:00 ` Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 09/16] powerpc/watchpoint: Convert thread_struct->hw_brk to an array Ravi Bangoria
2020-04-01 6:43 ` Christophe Leroy
2020-04-01 9:06 ` Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 10/16] powerpc/watchpoint: Use loop for thread_struct->ptrace_bps Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 11/16] powerpc/watchpoint: Introduce is_ptrace_bp() function Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 12/16] powerpc/watchpoint: Use builtin ALIGN*() macros Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 13/16] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint Ravi Bangoria
2020-04-01 6:50 ` Christophe Leroy
2020-04-01 9:13 ` Ravi Bangoria
2020-04-01 9:20 ` Christophe Leroy
2020-04-01 9:23 ` Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 14/16] powerpc/watchpoint: Don't allow concurrent perf and ptrace events Ravi Bangoria
2020-04-01 6:52 ` Christophe Leroy
2020-04-01 6:13 ` [PATCH v2 15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting Ravi Bangoria
2020-04-01 6:13 ` [PATCH v2 16/16] powerpc/watchpoint/xmon: Support 2nd dawr Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6a3ac3b-41c8-8a18-0f3d-ea4d4ef04db1@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=apopple@linux.ibm.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®