mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Connor McAdams <conmanx360@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Alastair Bridgewater <alastair.bridgewater@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] Add ZxR support + bugfixes
Date: Mon, 1 Oct 2018 23:03:28 +0900	[thread overview]
Message-ID: <f6aa819a-3db4-e457-8856-ad2debc85947@sakamocchi.jp> (raw)
In-Reply-To: <1538276607-30234-1-git-send-email-conmanx360@gmail.com>

Hi,

On Sep 30 2018 12:03, Connor McAdams wrote:
> This patch series adds support for the Sound Blaster ZxR, as well as a
> few bug fixes. This should be the last ca0132 based Creative card that
> needed support to be added.
> 
> Also, I did check to make sure each patch compiles properly this time,
> but you can check yourself just to be sure. :)
> 
> Connor McAdams (11):
>    ALSA: hda/ca0132 - Fix AE-5 control type
>    ALSA: hda/ca0132 - Fix surround sound with output effects
>    ALSA: hda/ca0132 - Add ZxR quirks + new quirk check function
>    ALSA: hda/ca0132 - Add ZxR pincfg
>    ALSA: hda/ca0132 - Add DBpro hda_codec_ops
>    ALSA: hda/ca0132 - Add ZxR init commands
>    ALSA: hda/ca0132 - Add ZxR DSP post-download commands
>    ALSA: hda/ca0132 - Add ZxR input/output select commands
>    ALSA: hda/ca0132 - Remove input select enum for ZxR
>    ALSA: hda/ca0132 - Add ZxR 600 ohm gain control
>    ALSA: hda/ca0132 - Add ZxR exit commands
> 
>   sound/pci/hda/patch_ca0132.c | 369 ++++++++++++++++++++++++++++++++++++++++---
>   1 file changed, 345 insertions(+), 24 deletions(-)

I reviewed the above patches and they looks good to be merged to
upstream.

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

I've already point some nitpickings but they can be solved
after merging them till next merge window.


Thanks

Takashi Sakamoto

  parent reply	other threads:[~2018-10-01 14:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-30  3:03 Connor McAdams
2018-09-30  3:03 ` [PATCH 01/11] ALSA: hda/ca0132 - Fix AE-5 control type Connor McAdams
2018-09-30  3:03 ` [PATCH 02/11] ALSA: hda/ca0132 - Fix surround sound with output effects Connor McAdams
2018-09-30  3:03 ` [PATCH 03/11] ALSA: hda/ca0132 - Add ZxR quirks + new quirk check function Connor McAdams
2018-09-30  3:03 ` [PATCH 04/11] ALSA: hda/ca0132 - Add ZxR pincfg Connor McAdams
2018-09-30  3:03 ` [PATCH 05/11] ALSA: hda/ca0132 - Add DBpro hda_codec_ops Connor McAdams
2018-10-01  2:10   ` Takashi Sakamoto
2018-09-30  3:03 ` [PATCH 06/11] ALSA: hda/ca0132 - Add ZxR init commands Connor McAdams
2018-09-30  3:03 ` [PATCH 07/11] ALSA: hda/ca0132 - Add ZxR DSP post-download commands Connor McAdams
2018-09-30  3:03 ` [PATCH 08/11] ALSA: hda/ca0132 - Add ZxR input/output select commands Connor McAdams
2018-09-30  3:03 ` [PATCH 09/11] ALSA: hda/ca0132 - Remove input select enum for ZxR Connor McAdams
2018-09-30  3:03 ` [PATCH 10/11] ALSA: hda/ca0132 - Add ZxR 600 ohm gain control Connor McAdams
2018-10-01  2:22   ` Takashi Sakamoto
2018-09-30  3:03 ` [PATCH 11/11] ALSA: hda/ca0132 - Add ZxR exit commands Connor McAdams
2018-10-01 14:03 ` Takashi Sakamoto [this message]
2018-10-02 15:23 ` [PATCH 00/11] Add ZxR support + bugfixes Takashi Iwai
2018-10-07 17:05   ` Connor McAdams
2018-10-08 15:10     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6aa819a-3db4-e457-8856-ad2debc85947@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alastair.bridgewater@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=conmanx360@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®