From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
steven.price@arm.com
Cc: boris.brezillon@collabora.com, robh@kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts
Date: Thu, 23 Nov 2023 11:40:53 +0100 [thread overview]
Message-ID: <f6abdc0e-400b-42dd-b685-73227fc0ee12@collabora.com> (raw)
In-Reply-To: <a881a1ca-8e10-4e07-ada5-7fef30c26470@linaro.org>
Il 23/11/23 11:39, Krzysztof Kozlowski ha scritto:
> On 23/11/2023 10:53, AngeloGioacchino Del Regno wrote:
>> Some SoCs may be equipped with a GPU containing two core groups
>> and this is exactly the case of Samsung's Exynos 5422 featuring
>> an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost
>> is partial, as this driver currently supports using only one
>> core group and that's reflected on all parts of it, including
>> the power on (and power off, previously to this patch) function.
>>
>> The issue with this is that even though executing the soft reset
>> operation should power off all cores unconditionally, on at least
>> one platform we're seeing a crash that seems to be happening due
>> to an interrupt firing which may be because we are calling power
>> transition only on the first core group, leaving the second one
>> unchanged, or because ISR execution was pending before entering
>> the panfrost_gpu_power_off() function and executed after powering
>> off the GPU cores, or all of the above.
>
> Does not apply - I tried next 20231117/21/22/23.
>
Sorry about that, I'll send a v2 soon.
Thanks,
Angelo
> Best regards,
> Krzysztof
>
> _______________________________________________
> Kernel mailing list -- kernel@mailman.collabora.com
> To unsubscribe send an email to kernel-leave@mailman.collabora.com
prev parent reply other threads:[~2023-11-23 10:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 9:53 AngeloGioacchino Del Regno
2023-11-23 10:35 ` Boris Brezillon
2023-11-23 11:15 ` AngeloGioacchino Del Regno
2023-11-23 11:43 ` AngeloGioacchino Del Regno
2023-11-23 12:59 ` Boris Brezillon
2023-11-23 13:24 ` AngeloGioacchino Del Regno
2023-11-23 13:51 ` Boris Brezillon
2023-11-23 15:14 ` AngeloGioacchino Del Regno
2023-11-23 15:40 ` Boris Brezillon
2023-11-24 9:17 ` AngeloGioacchino Del Regno
2023-11-24 10:12 ` AngeloGioacchino Del Regno
2023-11-24 10:21 ` Boris Brezillon
2023-11-24 10:48 ` AngeloGioacchino Del Regno
2023-11-23 10:39 ` Krzysztof Kozlowski
2023-11-23 10:40 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6abdc0e-400b-42dd-b685-73227fc0ee12@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®