mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: Daniel Vacek <neelx@suse.com>, dsterba@suse.cz
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>, Nick Terrell <terrelln@fb.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: zstd: add `zstd-fast` alias mount option for fast modes
Date: Tue, 15 Apr 2025 13:20:15 +0930	[thread overview]
Message-ID: <f6b92c77-d702-465b-a36a-93c42ecf59a8@suse.com> (raw)
In-Reply-To: <CAPjX3FfOJMFC8cXCqLa2yS1qSYmhu5cjV__+7xVRFGuKu=RqiA@mail.gmail.com>



在 2025/4/14 16:23, Daniel Vacek 写道:
> On Wed, 2 Apr 2025 at 16:31, Daniel Vacek <neelx@suse.com> wrote:
[...]
>> I'd still opt for keeping full range and functionality including
>> negative levels using the plain `zstd:N` option and having the other
>> just as an additional alias (for maybe being a bit nicer to some
>> humans, but not a big deal really and a matter of preference).
>> Checking the official documentation, it still mentions "negative
>> compression levels" being the fast option.
>>
>> https://facebook.github.io/zstd/
>> https://facebook.github.io/zstd/zstd_manual.html
>>
>> The deprecation part looks like just some gossip. It looks more about
>> the cli tool api and we are defining a kernel mount api - perfectly
>> unrelated.
> 
> Any feedback, Dave? I tend to drop this ida of `zstd-fast` alias.

Not Dave here, but if the future of "zstd-fast" is not that clear, we 
can definitely wait for a while.

It's always safer to adapt when the terminology is mature enough.

Thanks,
Qu

> 
>>> We can make this change before 6.15 final so it's not in any released
>>> kernel and we don't have to deal with compatibility.

  reply	other threads:[~2025-04-15  3:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31  8:23 Daniel Vacek
2025-03-31  8:49 ` Qu Wenruo
2025-03-31 10:06   ` Daniel Vacek
2025-03-31 21:14     ` Qu Wenruo
2025-03-31 22:57       ` David Sterba
2025-04-02  8:37         ` Daniel Vacek
2025-04-02  9:08           ` Qu Wenruo
2025-04-02 10:29             ` Daniel Vacek
2025-04-02 14:31         ` Daniel Vacek
2025-04-14  6:53           ` Daniel Vacek
2025-04-15  3:50             ` Qu Wenruo [this message]
2025-04-15 14:58               ` Nick Terrell
2025-04-15 16:56               ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6b92c77-d702-465b-a36a-93c42ecf59a8@suse.com \
    --to=wqu@suse.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neelx@suse.com \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®