mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: drago01 <drago01@gmail.com>
To: "Jeremy Fitzhardinge" <jeremy@goop.org>
Cc: "kernel list" <linux-kernel@vger.kernel.org>
Subject: [PATCH] Use EXPORT_SYMBOL for pv_lock_ops
Date: Wed, 20 Aug 2008 21:25:12 +0200	[thread overview]
Message-ID: <f6ca9fed0808201225p73a4303di3f806e8843c87f0a@mail.gmail.com> (raw)

On Wed, Aug 20, 2008 at 7:06 AM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> drago01 wrote:
>> Hi,
>>
>> It seems that in 2.6.27 pv_lock_ops is now GPL only which breaks
>> binary drivers because they pick it up implicitly when CONFIG_PARAVIRT
>> is enabled.
>> (see http://www.nvnews.net/vbulletin/showpost.php?p=1750090&postcount=2)
>> Is there a reason for doing this?
>> As some other pv_* are exported to all modules can this be done for
>> this too? (there should be no difference between CONFIG_PARAVIRT on or
>> of for GPL'd symbols).
>
> Yeah, they're just GPL by default, but the lock code is not exported GPL
> so there's no reason why lock_ops should be.
>
>    J
>
>

Use EXPORT_SYMBOL for pv_lock_ops to preserve the behavior between
CONFIG_PARAVIRT set and unset.
Currently we only used _GPL when the non paravirt symbols are GPL only too.

Signed-off-by: Adel Gadllah <adel.gadllah@gmail.com>

diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index 94da4d5..300da17 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -471,7 +471,7 @@ struct pv_lock_ops pv_lock_ops = {
        .spin_unlock = __ticket_spin_unlock,
 #endif
 };
-EXPORT_SYMBOL_GPL(pv_lock_ops);
+EXPORT_SYMBOL(pv_lock_ops);

 EXPORT_SYMBOL_GPL(pv_time_ops);
 EXPORT_SYMBOL    (pv_cpu_ops);

             reply	other threads:[~2008-08-20 19:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 19:25 drago01 [this message]
2008-08-20 19:29 ` drago01

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6ca9fed0808201225p73a4303di3f806e8843c87f0a@mail.gmail.com \
    --to=drago01@gmail.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®