* [PATCH] drm/omap: Fix error handling path in 'omap_dmm_probe()'
@ 2017-09-24 6:01 Christophe JAILLET
2017-09-28 6:23 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2017-09-24 6:01 UTC (permalink / raw)
To: tomi.valkeinen, airlied
Cc: dri-devel, linux-kernel, kernel-janitors, Christophe JAILLET
If we don't find a matching device node, we must free the memory allocated
in 'omap_dmm' a few lines above.
Fixes: 7cb0d6c17b96 ("drm/omap: fix TILER on OMAP5")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
index 1dd3dafc59af..c60a85e82c6d 100644
--- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
+++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
@@ -638,7 +638,8 @@ static int omap_dmm_probe(struct platform_device *dev)
match = of_match_node(dmm_of_match, dev->dev.of_node);
if (!match) {
dev_err(&dev->dev, "failed to find matching device node\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto fail;
}
omap_dmm->plat_data = match->data;
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/omap: Fix error handling path in 'omap_dmm_probe()'
2017-09-24 6:01 [PATCH] drm/omap: Fix error handling path in 'omap_dmm_probe()' Christophe JAILLET
@ 2017-09-28 6:23 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2017-09-28 6:23 UTC (permalink / raw)
To: Christophe JAILLET, airlied; +Cc: dri-devel, linux-kernel, kernel-janitors
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 24/09/17 09:01, Christophe JAILLET wrote:
> If we don't find a matching device node, we must free the memory allocated
> in 'omap_dmm' a few lines above.
>
> Fixes: 7cb0d6c17b96 ("drm/omap: fix TILER on OMAP5")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 1dd3dafc59af..c60a85e82c6d 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -638,7 +638,8 @@ static int omap_dmm_probe(struct platform_device *dev)
> match = of_match_node(dmm_of_match, dev->dev.of_node);
> if (!match) {
> dev_err(&dev->dev, "failed to find matching device node\n");
> - return -ENODEV;
> + ret = -ENODEV;
> + goto fail;
> }
>
> omap_dmm->plat_data = match->data;
>
Thanks! I have picked this up.
Tomi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-28 6:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-24 6:01 [PATCH] drm/omap: Fix error handling path in 'omap_dmm_probe()' Christophe JAILLET
2017-09-28 6:23 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®