mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: spi: qcom,spi-geni-qcom: Document QSPI support
@ 2026-10-30 13:30 Jyothi Kumar Seerapu
  2026-10-30 13:36 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Jyothi Kumar Seerapu @ 2026-10-30 13:30 UTC (permalink / raw)
  To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Andy Gross, Bjorn Andersson
  Cc: Krzysztof Kozlowski, linux-arm-msm, linux-spi, devicetree,
	linux-kernel, Jyothi Kumar Seerapu

Add the "qcom,geni-qspi" compatible to identify GENI Serial Engine
instances configured for QSPI operation.

The compatible also allows the driver to select the appropriate protocol
firmware when the Serial Engine is unconfigured (GENI_SE_INVALID_PROTO),
distinguishing between SPI and QSPI firmware.

Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
---
---
 Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
index edf399681d7a..e568b67d077e 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
@@ -19,6 +19,10 @@ description:
   SPI in master mode supports up to 50MHz, up to four chip selects,
   programmable data path from 4 bits to 32 bits and numerous protocol variants.
 
+  The "qcom,geni-qspi" compatible string identifies GENI serial engine
+  instances configured for QSPI operation. QSPI supports transfers over
+  multiple data lines for higher throughput than standard SPI.
+
   SPI Controller nodes must be child of GENI based Qualcomm Universal
   Peripharal. Please refer GENI based QUP wrapper controller node bindings
   described in Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml.
@@ -29,7 +33,9 @@ allOf:
 
 properties:
   compatible:
-    const: qcom,geni-spi
+    enum:
+      - qcom,geni-spi
+      - qcom,geni-qspi
 
   clocks:
     maxItems: 1

---
base-commit: 7079a12d7506b07fb53b54a664bfad5fa9b16d70
change-id: 20260916-qspi_dt_binding-8a1cb7a8772e

Best regards,
--  
Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: spi: qcom,spi-geni-qcom: Document QSPI support
  2026-10-30 13:30 [PATCH] dt-bindings: spi: qcom,spi-geni-qcom: Document QSPI support Jyothi Kumar Seerapu
@ 2026-10-30 13:36 ` Krzysztof Kozlowski
  2026-10-30 13:58   ` Jyothi Kumar Seerapu
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-30 13:36 UTC (permalink / raw)
  To: Jyothi Kumar Seerapu, Mark Brown, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, linux-spi, devicetree, linux-kernel

On 30/10/2026 14:30, Jyothi Kumar Seerapu wrote:
> Add the "qcom,geni-qspi" compatible to identify GENI Serial Engine
> instances configured for QSPI operation.
> 
> The compatible also allows the driver to select the appropriate protocol
> firmware when the Serial Engine is unconfigured (GENI_SE_INVALID_PROTO),
> distinguishing between SPI and QSPI firmware.
> 
> Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>

Where is any user of this? You speak about driver, but there is no driver.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: spi: qcom,spi-geni-qcom: Document QSPI support
  2026-10-30 13:36 ` Krzysztof Kozlowski
@ 2026-10-30 13:58   ` Jyothi Kumar Seerapu
  0 siblings, 0 replies; 3+ messages in thread
From: Jyothi Kumar Seerapu @ 2026-10-30 13:58 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Mark Brown, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Andy Gross, Bjorn Andersson
  Cc: linux-arm-msm, linux-spi, devicetree, linux-kernel



On 10/30/2026 7:06 PM, Krzysztof Kozlowski wrote:
> On 30/10/2026 14:30, Jyothi Kumar Seerapu wrote:
>> Add the "qcom,geni-qspi" compatible to identify GENI Serial Engine
>> instances configured for QSPI operation.
>>
>> The compatible also allows the driver to select the appropriate protocol
>> firmware when the Serial Engine is unconfigured (GENI_SE_INVALID_PROTO),
>> distinguishing between SPI and QSPI firmware.
>>
>> Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
> 
> Where is any user of this? You speak about driver, but there is no driver.
> 
Thanks for the review. This patch only adds the QSPI binding change. The 
corresponding driver changes to add QSPI support will be submitted in an 
upcoming separate patch.
  > Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-30 13:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-30 13:30 [PATCH] dt-bindings: spi: qcom,spi-geni-qcom: Document QSPI support Jyothi Kumar Seerapu
2026-10-30 13:36 ` Krzysztof Kozlowski
2026-10-30 13:58   ` Jyothi Kumar Seerapu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®