mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
	"John B. Wyatt IV" <jwyatt@redhat.com>,
	John Kacur <jkacur@redhat.com>, Peng Fan <peng.fan@nxp.com>,
	"open list:CPU POWER MONITORING SUBSYSTEM"
	<linux-pm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] pm: cpupower: Makefile: Fix cross compilation
Date: Tue, 7 Jan 2025 13:38:42 -0700	[thread overview]
Message-ID: <f727eb90-4ed9-4d8d-856c-2de526d97795@linuxfoundation.org> (raw)
In-Reply-To: <3b55d23b-aa37-4187-9649-aef663ee1de8@broadcom.com>

On 1/7/25 11:56, Florian Fainelli wrote:
> On 12/9/24 16:58, Shuah Khan wrote:
>> On 12/2/24 10:12, Florian Fainelli wrote:
>>> On 11/28/24 17:20, Peng Fan (OSS) wrote:
>>>> From: Peng Fan <peng.fan@nxp.com>
>>>>
>>>> After commit f79473ed9220 ("pm: cpupower: Makefile: Allow overriding
>>>> cross-compiling env params") we would fail to cross compile cpupower in
>>>> buildroot which uses the recipe at [1] where only the CROSS variable is
>>>> being set.
>>>>
>>>> The issue here is the use of the lazy evaluation for all variables: CC,
>>>> LD, AR, STRIP, RANLIB, rather than just CROSS.
>>>>
>>>> [1]:
>>>> https://git.buildroot.net/buildroot/tree/package/linux-tools/linux- tool-cpupower.mk.in
>>>>
>>>> Fixes: f79473ed9220 ("pm: cpupower: Makefile: Allow overriding cross- compiling env params")
>>>> Reported-by: Florian Fainelli <florian.fainelli@broadcom.com>
>>>> Closes: https://lore.kernel.org/all/2bbabd2c-24ef-493c- a199-594e5dada3da@broadcom.com/
>>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>>
>>> Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
>>>
>>> Thanks!
>>
>> Thank you. Applied to linux-cpupower for my next full request to
>> Rafael.
> 
> Since this is a bug fix, any chance you can fast track that change so we can keep on building that tool in various environments?
> 

I am planning to send pull request to Rafael later on today.
It will be available in linux-next once Rafael pulls it in.

I don't think if it can be fast tracked with the vacations
and holidays for the past 3 weeks or so. The best I can do
is getting this into linux-next

thanks,
-- Shuah


  reply	other threads:[~2025-01-07 20:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29  1:20 Peng Fan (OSS)
2024-12-02 17:12 ` Florian Fainelli
2024-12-10  0:58   ` Shuah Khan
2025-01-07 18:56     ` Florian Fainelli
2025-01-07 20:38       ` Shuah Khan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-21  4:43 Florian Fainelli
2024-11-22 15:25 ` Shuah Khan
2024-11-22 16:11   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f727eb90-4ed9-4d8d-856c-2de526d97795@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=jkacur@redhat.com \
    --cc=jwyatt@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®