mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Icenowy Zheng <icenowy@aosc.io>
To: Chen-Yu Tsai <wens@csie.org>, LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: axboe@kernel.dk, Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-ide@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 09/13] ARM: dts: sun8i: r40: add sata node
Date: Fri, 31 Aug 2018 20:57:56 +0800	[thread overview]
Message-ID: <f742ef4cd28c4dd3be6b0c64fcb8b8a33635ec8e.camel@aosc.io> (raw)
In-Reply-To: <CAGb2v65H_Aog294NYAmcTGARGiOiyCDy=MT9g8ed=Cxr8Bm3Qg@mail.gmail.com>

在 2018-08-31五的 19:10 +0800,Chen-Yu Tsai写道:
> On Fri, Aug 31, 2018 at 5:29 PM Corentin Labbe
> <clabbe.montjoie@gmail.com> wrote:
> > 
> > On Fri, Aug 31, 2018 at 03:58:34PM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Aug 31, 2018 at 3:56 PM Corentin Labbe
> > > <clabbe.montjoie@gmail.com> wrote:
> > > > 
> > > > On Fri, Aug 31, 2018 at 09:35:00AM +0200, Maxime Ripard wrote:
> > > > > On Thu, Aug 30, 2018 at 09:01:16PM +0200, Corentin Labbe
> > > > > wrote:
> > > > > > R40 have a sata controller which is the same as A20.
> > > > > > This patch adds a DT node for it.
> > > > > > 
> > > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > > > > > ---
> > > > > >  arch/arm/boot/dts/sun8i-r40.dtsi | 23
> > > > > > +++++++++++++++++++++++
> > > > > >  1 file changed, 23 insertions(+)
> > > > > > 
> > > > > > diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi
> > > > > > b/arch/arm/boot/dts/sun8i-r40.dtsi
> > > > > > index 852c2ccc3268..d6b5820da850 100644
> > > > > > --- a/arch/arm/boot/dts/sun8i-r40.dtsi
> > > > > > +++ b/arch/arm/boot/dts/sun8i-r40.dtsi
> > > > > > @@ -550,6 +550,29 @@
> > > > > >                     #size-cells = <0>;
> > > > > >             };
> > > > > > 
> > > > > > +           ahci: sata@1c18000 {
> > > > > > +                   compatible = "allwinner,sun8i-r40-
> > > > > > ahci";
> > > > > > +                   reg = <0x01c18000 0x1000>;
> > > > > > +                   interrupts = <GIC_SPI 56
> > > > > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > +                   clocks = <&ccu CLK_BUS_SATA>, <&ccu
> > > > > > CLK_SATA>;
> > > > > > +                   resets = <&ccu RST_BUS_SATA>;
> > > > > > +                   resets-name = "ahci";
> > > > > > +                   #address-cells = <1>;
> > > > > > +                   #size-cells = <0>;
> > > > > > +                   status = "disabled";
> > > > > > +
> > > > > > +                   sata_port: sata-port@0 {
> > > > > > +                           reg = <0>;
> > > > > > +                           phys = <&sata_phy>;
> > > > > > +                   };
> > > > > > +           };
> > > > > > +
> > > > > > +           sata_phy: sata-phy@1c180c0  {
> > > > > > +                   compatible = "allwinner,sun8i-r40-sata-
> > > > > > phy";
> > > > > > +                   reg = <0x1c180c0 0x200>;
> > > > > 
> > > > > Overlapping devices in the DTS is not ok.
> > > > > 
> > > > 
> > > > I do the same than arch/arm/boot/dts/berlin2.dtsi (sata@e90000 
> > > > phy@e900a0)
> > > > But since it is not a good justification, it seems that regmap
> > > > is my only solution ?
> > > 
> > > Since you are effectively splitting one device node into two, you
> > > should
> > > adjust the original (ahci) device nodes register range.
> > > 
> > 
> > I cannot do that if I remove patch 13, iow If I keep phy init code
> > in both place as you requested.
> 
> Then you need to split the phy handling between a10 and r40. A10
> doesn't
> need phy-supply at the moment anyway. And migrating A10 to newer
> binding
> is only causing you problems anyway. Just drop that part, and handle
> the
> R40.

From the hardware perspective, they're the same. The A10/A20 has also
two dedicated VDD pins for SATA, although on boards they're usually
always on.

> 
> ChenYu
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


  reply	other threads:[~2018-08-31 12:58 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 19:01 [PATCH v4 00/13] ata: ahci_platform: support allwinner R40 AHCI Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 01/13] dt-bindings: ata: ahci-platform: fix indentation of target-supply Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 02/13] ata: ahci_platform: add support for AHCI controller regulator Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 03/13] dt-bindings: ata: ahci-platform: document ahci-supply Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 04/13] phy: Add sun4i-a10-phy-sata driver Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 05/13] dt-bindings: phy: document sun4i-a10-sata-phy Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 06/13] dt-bindings: ata: update ahci_sunxi bindings Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 07/13] ata: ahci_sunxi: Bypass PHY init when using the new binding Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 08/13] ata: ahci_sunxi: add support for r40 Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 09/13] ARM: dts: sun8i: r40: add sata node Corentin Labbe
2018-08-31  7:35   ` Maxime Ripard
2018-08-31  7:56     ` Corentin Labbe
2018-08-31  7:58       ` Chen-Yu Tsai
2018-08-31  9:29         ` Corentin Labbe
2018-08-31 11:10           ` Chen-Yu Tsai
2018-08-31 12:57             ` Icenowy Zheng [this message]
2018-08-31 10:20       ` maxime.ripard
2018-08-31 10:54         ` Corentin Labbe
2018-08-31 11:31           ` Chen-Yu Tsai
2018-08-31 12:08             ` Corentin Labbe
2018-08-31 12:58             ` Icenowy Zheng
2018-08-30 19:01 ` [PATCH v4 10/13] ARM: dts: sun8i: sun8i-r40-bananapi-m2-ultra: enable AHCI Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 11/13] ARM: dts: sun7i: a20: add sata-port/sata-phy nodes Corentin Labbe
2018-08-30 19:01 ` [PATCH v4 12/13] ARM: dts: sun4i: a10: " Corentin Labbe
2018-08-31  7:37   ` Maxime Ripard
2018-08-31  7:53     ` Corentin Labbe
2018-08-31 10:21       ` Maxime Ripard
2018-08-30 19:01 ` [PATCH v4 13/13 DONOTMERGE] ata: ahci_sunxi: remove PHY code Corentin Labbe
2018-08-30 20:27   ` Hans de Goede
2018-08-30 20:24 ` [PATCH v4 00/13] ata: ahci_platform: support allwinner R40 AHCI Hans de Goede
2018-08-30 20:31 ` Jens Axboe
2018-08-31  2:32   ` Chen-Yu Tsai
2018-08-31  2:52     ` Jens Axboe
2018-08-31  7:40       ` Maxime Ripard
2018-08-31 14:35         ` Jens Axboe
2018-09-03  8:31           ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f742ef4cd28c4dd3be6b0c64fcb8b8a33635ec8e.camel@aosc.io \
    --to=icenowy@aosc.io \
    --cc=axboe@kernel.dk \
    --cc=clabbe.montjoie@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®