* [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity
@ 2026-10-29 8:42 Zhiyuan Sheng
2026-10-29 8:47 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zhiyuan Sheng @ 2026-10-29 8:42 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, cheng.jiang, wei.deng,
shuai.zhang, xiuzhuo.shang, jinwang.li, Zhiyuan Sheng
The W_DISABLE2# signal of the M.2 E key connector is active-low as
defined in the PCI Express M.2 Specification. Fix the w-disable2-gpios
polarity by using GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH.
Signed-off-by: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza-evk.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
index 6c5cc47a183e..2e380ffee658 100644
--- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
@@ -98,7 +98,7 @@ connector-0 {
compatible = "pcie-m2-e-connector";
vpcie3v3-supply = <&vreg_pcie_m_3p3>;
w-disable1-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
- w-disable2-gpios = <&pm8550vs_g_gpios 4 GPIO_ACTIVE_HIGH>;
+ w-disable2-gpios = <&pm8550vs_g_gpios 4 GPIO_ACTIVE_LOW>;
pinctrl-0 = <&m2_w_disable1>, <&m2_w_disable2>;
pinctrl-names = "default";
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity
2026-10-29 8:42 [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity Zhiyuan Sheng
@ 2026-10-29 8:47 ` Konrad Dybcio
2026-10-29 8:47 ` Konrad Dybcio
2026-10-29 8:54 ` Abel Vesa
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-10-29 8:47 UTC (permalink / raw)
To: Zhiyuan Sheng, Bjorn Andersson, Konrad Dybcio
Cc: Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, cheng.jiang, wei.deng,
shuai.zhang, xiuzhuo.shang, jinwang.li
On 10/29/26 9:42 AM, Zhiyuan Sheng wrote:
> The W_DISABLE2# signal of the M.2 E key connector is active-low as
> defined in the PCI Express M.2 Specification. Fix the w-disable2-gpios
> polarity by using GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH.
>
> Signed-off-by: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity
2026-10-29 8:42 [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity Zhiyuan Sheng
2026-10-29 8:47 ` Konrad Dybcio
@ 2026-10-29 8:47 ` Konrad Dybcio
2026-10-29 8:54 ` Abel Vesa
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-10-29 8:47 UTC (permalink / raw)
To: Zhiyuan Sheng, Bjorn Andersson, Konrad Dybcio
Cc: Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, cheng.jiang, wei.deng,
shuai.zhang, xiuzhuo.shang, jinwang.li
On 10/29/26 9:42 AM, Zhiyuan Sheng wrote:
> The W_DISABLE2# signal of the M.2 E key connector is active-low as
> defined in the PCI Express M.2 Specification. Fix the w-disable2-gpios
> polarity by using GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH.
>
> Signed-off-by: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
> ---
Fixes: 073c6a891eb3 ("arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector")
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity
2026-10-29 8:42 [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity Zhiyuan Sheng
2026-10-29 8:47 ` Konrad Dybcio
2026-10-29 8:47 ` Konrad Dybcio
@ 2026-10-29 8:54 ` Abel Vesa
2 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2026-10-29 8:54 UTC (permalink / raw)
To: Zhiyuan Sheng
Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, cheng.jiang, wei.deng, shuai.zhang, xiuzhuo.shang,
jinwang.li
On 26-10-29 16:42:03, Zhiyuan Sheng wrote:
> The W_DISABLE2# signal of the M.2 E key connector is active-low as
> defined in the PCI Express M.2 Specification. Fix the w-disable2-gpios
> polarity by using GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH.
>
> Signed-off-by: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
With fixes tag, this looks good to me, so:
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-29 8:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 8:42 [PATCH v1] arm64: dts: qcom: eliza-evk: Fix M.2 W_DISABLE2# GPIO polarity Zhiyuan Sheng
2026-10-29 8:47 ` Konrad Dybcio
2026-10-29 8:47 ` Konrad Dybcio
2026-10-29 8:54 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®