mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Justin Vargas <justinyvar@gmail.com>,
	Hans de Goede <hansg@kernel.org>,
	 Krishna Chomal <krishna.chomal108@gmail.com>
Cc: jlee@suse.com, W_Armin@gmx.de,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: acer-wmi: Remove unused platform_profile_support variable
Date: Fri, 18 Sep 2026 20:35:17 +0300 (EEST)	[thread overview]
Message-ID: <f76315ab-b16c-e4e3-c3c0-6d7963e9671d@linux.intel.com> (raw)
In-Reply-To: <20260902193039.21725-1-justinyvar@gmail.com>

On Wed, 2 Sep 2026, Justin Vargas wrote:

> The platform_profile_support variable is assigned during platform
> profile setup but is never read anywhere in the driver. Remove it.
> 
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Justin Vargas <justinyvar@gmail.com>
> ---
> Found while reading through the driver. Compile tested only, as this
> is a pure dead-code removal.
> 
> hp-wmi.c and asus-wmi.c appear to carry the same unused variable -
> declared and assigned once, never read. All three were converted to
> devm_platform_profile_register() in the same series, which may be where
> the last reader went, though my clone is too shallow to confirm that.
> Happy to send patches for the other two as well if that is useful; I
> left them out here to keep this patch focused on the driver I use.
> 
> If the intent was for this variable to be checked somewhere rather than
> removed, let me know and I will send that instead.

Now this is interesting, git grep finds 6 platform_profile_support words 
(3 variables in two drivers) and none of them are in use. :-/

I'm not convinced there's going to be any use for any of them, probably 
leftover from past. Can you make a series to remove them all, one patch 
per driver.

-- 
 i.

      reply	other threads:[~2026-09-18 17:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 19:30 Justin Vargas
2026-09-18 17:35 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f76315ab-b16c-e4e3-c3c0-6d7963e9671d@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=hansg@kernel.org \
    --cc=jlee@suse.com \
    --cc=justinyvar@gmail.com \
    --cc=krishna.chomal108@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®