From: Samuel Cabrero <scabrero@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Steve French <sfrench@samba.org>
Cc: Aurelien Aptel <aaptel@suse.com>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] cifs: Delete a stray unlock in cifs_swn_reconnect()
Date: Thu, 17 Dec 2020 12:40:18 +0100 [thread overview]
Message-ID: <f7dfcf49dbfebeaf49e2f36d8c72e34c74a32fb5.camel@suse.de> (raw)
In-Reply-To: <X9s6nGDLt4xreaYN@mwanda>
On Thu, 2020-12-17 at 14:01 +0300, Dan Carpenter wrote:
> The unlock is done in the caller, this is a stray which leads to a
> double unlock bug.
>
Indeed.
Reviewed-by: Samuel Cabrero <scabrero@suse.de>
--
Samuel Cabrero / SUSE Labs Samba Team
GPG: D7D6 E259 F91C F0B3 2E61 1239 3655 6EC9 7051 0856
scabrero@suse.com
scabrero@suse.de
prev parent reply other threads:[~2020-12-17 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 11:01 Dan Carpenter
2020-12-17 11:40 ` Samuel Cabrero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7dfcf49dbfebeaf49e2f36d8c72e34c74a32fb5.camel@suse.de \
--to=scabrero@suse.de \
--cc=aaptel@suse.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=scabrero@suse.com \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®