* [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization
@ 2025-08-18 12:36 Liao Yuanhong
2025-08-18 13:13 ` Paul Menzel
2025-08-18 19:00 ` Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: Liao Yuanhong @ 2025-08-18 12:36 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz,
open list:BLUETOOTH DRIVERS, open list
Cc: Liao Yuanhong
The hci_uart struct is already zeroed by kzalloc(). It's redundant to
initialize hu->padding to 0.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
drivers/bluetooth/hci_ldisc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index d0adae3267b4..e7a55c2e63f1 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -508,7 +508,6 @@ static int hci_uart_tty_open(struct tty_struct *tty)
/* disable alignment support by default */
hu->alignment = 1;
- hu->padding = 0;
/* Use serial port speed as oper_speed */
hu->oper_speed = tty->termios.c_ospeed;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization
2025-08-18 12:36 [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization Liao Yuanhong
@ 2025-08-18 13:13 ` Paul Menzel
2025-08-18 19:00 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Paul Menzel @ 2025-08-18 13:13 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Marcel Holtmann, Luiz Augusto von Dentz, linux-bluetooth, linux-kernel
Dear Liao,
Thank you for the patch.
Am 18.08.25 um 14:36 schrieb Liao Yuanhong:
> The hci_uart struct is already zeroed by kzalloc(). It's redundant to
> initialize hu->padding to 0.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> drivers/bluetooth/hci_ldisc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
> index d0adae3267b4..e7a55c2e63f1 100644
> --- a/drivers/bluetooth/hci_ldisc.c
> +++ b/drivers/bluetooth/hci_ldisc.c
> @@ -508,7 +508,6 @@ static int hci_uart_tty_open(struct tty_struct *tty)
>
> /* disable alignment support by default */
> hu->alignment = 1;
> - hu->padding = 0;
>
> /* Use serial port speed as oper_speed */
> hu->oper_speed = tty->termios.c_ospeed;
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization
2025-08-18 12:36 [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization Liao Yuanhong
2025-08-18 13:13 ` Paul Menzel
@ 2025-08-18 19:00 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2025-08-18 19:00 UTC (permalink / raw)
To: Liao Yuanhong, linux-bluetooth
Cc: LKML, Luiz Von Dentz, Marcel Holtmann, Paul Menzel
> The hci_uart struct is already zeroed by kzalloc(). It's redundant to
> initialize hu->padding to 0.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc2#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-18 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-18 12:36 [PATCH] Bluetooth: hci_ldisc: Remove redundant 0 value initialization Liao Yuanhong
2025-08-18 13:13 ` Paul Menzel
2025-08-18 19:00 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®