Makefile in libfdt shows non-existent files

Makefile in libfdt shows non-existent files

[Kyle Yan]

Hi Rob,

I was trying the latest dtc as on Linux 4.12 for device tree overlay. On 
the latest kernel, I see the following commit:

commit 6f05afcbb031722ec1eff77dde188ff2edf8940e ("scripts/dtc: Update to 
upstream version 0931cea3ba20")

This seems to pull in various upstream dtc commits for dtc overlay 
including:

commit 0cdd06c5135bd9f46853c2f58ad2ac91b0fa87f3 ("libfdt: Add overlay 
application function")

The upstream commit introduces libfdt/fdt_overlay.c, but this file is 
not reflected in the kernel. Similar case is also seen for 
libfdt/fdt_addresses.c.

Can you help confirm if these files should indeed have been pulled into 
the kernel and if anything else is missing from DTC side.

Thanks,

Kyle

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: Makefile in libfdt shows non-existent files

[Rob Herring]

On Fri, Jul 14, 2017 at 7:52 PM, Kyle Yan <kyan@codeaurora.org> wrote:
> Hi Rob,
>
> I was trying the latest dtc as on Linux 4.12 for device tree overlay. On the
> latest kernel, I see the following commit:
>
> commit 6f05afcbb031722ec1eff77dde188ff2edf8940e ("scripts/dtc: Update to
> upstream version 0931cea3ba20")
>
> This seems to pull in various upstream dtc commits for dtc overlay
> including:
>
> commit 0cdd06c5135bd9f46853c2f58ad2ac91b0fa87f3 ("libfdt: Add overlay
> application function")
>
> The upstream commit introduces libfdt/fdt_overlay.c, but this file is not
> reflected in the kernel. Similar case is also seen for
> libfdt/fdt_addresses.c.

Indeed. The update-dtc-source.sh script has an explicit list of files to copy.

> Can you help confirm if these files should indeed have been pulled into the
> kernel and if anything else is missing from DTC side.

Yes, though the kernel doesn't need them so it doesn't matter too much.

Rob