mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Heming Zhao <heming.zhao@suse.com>, Mark Fasheh <mark@fasheh.com>,
	Joel Becker <jlbec@evilplan.org>,
	ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] ocfs2: fix stale xattr entry pointers and empty header reads
Date: Sun, 25 Oct 2026 22:54:34 +0800	[thread overview]
Message-ID: <f81c41b2-a4a0-43ef-8e68-a4da92644267@linux.alibaba.com> (raw)
In-Reply-To: <20261024103709.7ada16bbca6403787892cb5c@linux-foundation.org>



On 10/25/26 1:37 AM, Andrew Morton wrote:
> On Sat, 24 Oct 2026 23:10:06 +0800 Joseph Qi <joseph.qi@linux.alibaba.com> wrote:
> 
>> Five defects in the ocfs2 extended attribute code, plus one robustness
>> measure that belongs with them, all on the paths that move entries
>> between a block, a bucket and an index tree.  They fall into two groups.
>>
> 
> Thanks.
> 
> The series is a little awkward - [1/6] is "no functional change" hence
> it's upstream-in-7.5-rc1 material.
> 
> The other 5 are cc:stable fixes, so they're upstream-in-7.4-rcX material.
> 
> That means splitting the series and it means upstreaming an untested
> code combination - 2-5 haven't been tested without the presence of
> [1/6].
> 
> I think I'll just cheat a bit.  I'll keep all 6 together and I'll put
> them in mm-nonmm-unstable for now.  After Linus releases 7.4-rc1 I'll
> move all 6 into mm-nonmm-hotfixes-unstable for upstreaming during the
> 7.4-rcX cycle.
> 
> I'll add 
> 
> Fixes: e39baff18b85 ("ocfs2: use the stored hash when checking xattr bucket collision")
> 
> to [1/6] just to make things look better and to reduce the risk
> associated with -stable running that untested code combination.

Keeping all six together works fine for me, thanks.

Joseph

      reply	other threads:[~2026-10-25 14:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 15:10 Joseph Qi
2026-10-24 15:10 ` [PATCH 1/6] ocfs2: read the xattr entry hash before defragmenting the bucket Joseph Qi
2026-10-24 15:10 ` [PATCH 2/6] ocfs2: find the xattr entry again after defragmenting a bucket Joseph Qi
2026-10-24 15:10 ` [PATCH 3/6] ocfs2: find the xattr entry again after converting a block to " Joseph Qi
2026-10-24 15:10 ` [PATCH 4/6] ocfs2: do not read the entry array of an empty xattr bucket Joseph Qi
2026-10-24 15:10 ` [PATCH 5/6] ocfs2: do not index before the entry array when dividing an empty bucket Joseph Qi
2026-10-24 15:10 ` [PATCH 6/6] ocfs2: do not read the entry array of an empty xattr block Joseph Qi
2026-10-24 17:37 ` [PATCH 0/6] ocfs2: fix stale xattr entry pointers and empty header reads Andrew Morton
2026-10-25 14:54   ` Joseph Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f81c41b2-a4a0-43ef-8e68-a4da92644267@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=heming.zhao@suse.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®