From: Stefan Agner <stefan@agner.ch>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Russell King <linux@armlinux.org.uk>,
Will Deacon <will.deacon@arm.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
julien.thierry@arm.com, Mark Rutland <mark.rutland@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: drop -mauto-it
Date: Tue, 05 Mar 2019 23:40:08 +0100 [thread overview]
Message-ID: <f822090431e21d31b0b4fcd98c983d60@agner.ch> (raw)
In-Reply-To: <CAKwvOd=1sEfg94kg6gbjCrrn3Wcp7BuwWKtGdD9pr_+P03eTMQ@mail.gmail.com>
On 05.03.2019 23:21, Nick Desaulniers wrote:
> On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner <stefan@agner.ch> wrote:
>>
>> The assembler option -mauto-it is no longer a valid option. It has
>> been removed from the documentation in July 2009, which is well
>> before the release date of the currently supported binutils version
>> 2.20.
>
> Do you by chance have a link to the relevant commit?
>
Documentation got removed in
https://github.com/bminor/binutils-gdb/commit/529707530657a333a304c651c808ea630c955223
I think -mauto-it never really made it upstream. Documentation has been
introduced here, but it seems that the option already has been renamed:
https://github.com/bminor/binutils-gdb/commit/e07e6e58be1c5273ed79a25c80ba831e71ac86b1
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
>> arch/arm/Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
>> index 9561325c5201..ebf67bebe73d 100644
>> --- a/arch/arm/Makefile
>> +++ b/arch/arm/Makefile
>> @@ -113,8 +113,7 @@ CFLAGS_ABI +=-funwind-tables
>> endif
>>
>> ifeq ($(CONFIG_THUMB2_KERNEL),y)
>> -AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it)
>> -CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT)
>> +CFLAGS_ISA :=-mthumb -Wa$(comma)-mimplicit-it=always
>
> Is $(comma) still needed? I thought it was only needed when a flag
> that would contain commas would be in another set of parens (thus
> making an ambiguity), like cc-ldoption or such? Can you replace
> `$(comma)` here with `,`? I suspect it should work.
Could catch, yes comma should work here.
--
Stefan
next prev parent reply other threads:[~2019-03-05 22:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 22:18 [PATCH 1/2] ARM: drop unnecessary WASM Stefan Agner
2019-03-05 22:18 ` [PATCH 2/2] ARM: drop -mauto-it Stefan Agner
2019-03-05 22:21 ` Nick Desaulniers
2019-03-05 22:40 ` Stefan Agner [this message]
2019-03-05 23:20 ` Nick Desaulniers
2019-03-05 23:39 ` [PATCH 1/2] ARM: drop unnecessary WASM Robin Murphy
2019-03-06 0:47 ` Nick Desaulniers
2019-03-17 15:44 ` Stefan Agner
2019-03-06 7:58 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f822090431e21d31b0b4fcd98c983d60@agner.ch \
--to=stefan@agner.ch \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nicolas.pitre@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome