* [PATCH 1/1] fbdev: mmp: fix value check in mmphw_probe()
@ 2023-07-27 17:03 Yuanjun Gong
2023-07-31 12:43 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Yuanjun Gong @ 2023-07-27 17:03 UTC (permalink / raw)
To: Helge Deller, Christophe JAILLET, Lisa Du, linux-fbdev, linux-kernel
Cc: Yuanjun Gong
in mmphw_probe(), check the return value of clk_prepare_enable()
and return the error code if clk_prepare_enable() returns an
unexpected value.
Fixes: d63028c38905 ("video: mmp display controller support")
Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com>
---
drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
index 51fbf02a0343..76b50b6c98ad 100644
--- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
+++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
@@ -519,7 +519,9 @@ static int mmphw_probe(struct platform_device *pdev)
"unable to get clk %s\n", mi->clk_name);
goto failed;
}
- clk_prepare_enable(ctrl->clk);
+ ret = clk_prepare_enable(ctrl->clk);
+ if (ret)
+ goto failed;
/* init global regs */
ctrl_set_default(ctrl);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] fbdev: mmp: fix value check in mmphw_probe()
2023-07-27 17:03 [PATCH 1/1] fbdev: mmp: fix value check in mmphw_probe() Yuanjun Gong
@ 2023-07-31 12:43 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2023-07-31 12:43 UTC (permalink / raw)
To: Yuanjun Gong, Christophe JAILLET, Lisa Du, linux-fbdev, linux-kernel
On 7/27/23 19:03, Yuanjun Gong wrote:
> in mmphw_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
>
> Fixes: d63028c38905 ("video: mmp display controller support")
> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> index 51fbf02a0343..76b50b6c98ad 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c
> @@ -519,7 +519,9 @@ static int mmphw_probe(struct platform_device *pdev)
> "unable to get clk %s\n", mi->clk_name);
> goto failed;
> }
> - clk_prepare_enable(ctrl->clk);
> + ret = clk_prepare_enable(ctrl->clk);
> + if (ret)
> + goto failed;
>
> /* init global regs */
> ctrl_set_default(ctrl);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-31 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-27 17:03 [PATCH 1/1] fbdev: mmp: fix value check in mmphw_probe() Yuanjun Gong
2023-07-31 12:43 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®