Re: [PATCH V1 3/3] arm64: dts: qcom: sm8750: Add SDC2 nodes for sm8750 mtp and qrd board

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/7/25 7:44 AM, Sarthak Garg wrote:
> Enable SD Card host controller for sm8750 mtp and qrd board.
> 
> Signed-off-by: Sarthak Garg <sarthak.garg@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 +++++++++++++++
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 16 ++++++++++++++++

Normally this should be one commit per board, with e.g. "sm8750-mtp:"
in the title


>  2 files changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> index 3bbb53b7c71f..26548191d95d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> @@ -1030,6 +1030,21 @@ &remoteproc_mpss {
>  	status = "fail";
>  };
>  
> +&sdhc_2 {
> +	cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
> +	vmmc-supply = <&vreg_l9b_2p9>;
> +	vqmmc-supply = <&vreg_l8b_1p8>;

Any reason you didn't place a \n here..

> +
> +	no-sdio;
> +	no-mmc;
> +
> +	pinctrl-0 = <&sdc2_default>;
> +	pinctrl-1 = <&sdc2_sleep>;
> +	pinctrl-names = "default", "sleep";
> +
> +	status = "okay";
> +};
> +
>  &swr0 {
>  	status = "okay";
>  
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..8d018eef44da 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -916,6 +916,22 @@ &remoteproc_mpss {
>  	status = "okay";
>  };
>  
> +&sdhc_2 {
> +	cd-gpios = <&tlmm 55 GPIO_ACTIVE_LOW>;
> +
> +	vmmc-supply = <&vreg_l9b_2p9>;
> +	vqmmc-supply = <&vreg_l8b_1p8>;

..but added one here?

FWIW I like the 2nd one more

Konrad