mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <llong@redhat.com>
To: Vlastimil Babka <vbabka@suse.cz>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Waiman Long <llong@redhat.com>
Cc: Thomas Gleixner <tglx@kernel.org>, Marc Zyngier <maz@kernel.org>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
	Alexei Starovoitov <ast@kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3-its: Don't acquire rt_spin_lock in allocate_vpe_l1_table()
Date: Wed, 21 Jan 2026 11:37:49 -0500	[thread overview]
Message-ID: <f8ba00be-d98c-4962-a32a-98ac0ddef9b2@redhat.com> (raw)
In-Reply-To: <0c33bdee-6de8-4d9f-92ca-4f72c1b6fb9f@suse.cz>

On 1/14/26 12:59 PM, Vlastimil Babka wrote:
> On 1/13/26 12:55, Sebastian Andrzej Siewior wrote:
>> On 2026-01-12 12:14:30 [-0500], Waiman Long wrote:
>>> On 1/12/26 10:09 AM, Thomas Gleixner wrote:
>>>> They might be acquired though. Only alloc_pages_nolock() guarantees that
>>>> no lock is taken IIRC.
>>> Thanks for the suggestion. I will look into using that for page allocation.
>>> I had actually attempt to use kmalloc_nolock() to replace kzalloc()
>>> initially. Even though it removed the call to rmqueue(), but there were
>>> other spinlocks in the slub code that were still being acquired like the
>>> local_lock() or the spinlock in the get_random() code. So I gave up using
> Hmm if get_random() code takes a spinlock, we have an unsolved
> incompatibility with kmalloc_nolock() and CONFIG_SLAB_FREELIST_RANDOM.
>
>>> that. Anyway, kmalloc_nolock() doesn't seem to be fully working yet.
>> with kmalloc_nolock() you have to be able to deal with a NULL pointer.
> Yes. So even after we fix the current problems with incompatible context, I
> think kmalloc_nolock() would still be a bad fit for hw bringup code that
> should not really fail. Because the possibility of failure will always
> exist. The BPF use case that motivated it is quite different.

Yes, it is an issue too that kmalloc_nolock() may fail. If that happens, 
we don't have another good alternative.

Cheers,
Longman


  reply	other threads:[~2026-01-21 16:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 21:53 Waiman Long
2026-01-08  8:26 ` Marc Zyngier
2026-01-08 22:11   ` Thomas Gleixner
2026-01-09 16:13     ` Marc Zyngier
2026-01-11  9:39       ` Thomas Gleixner
2026-01-11 10:38         ` Marc Zyngier
2026-01-11 16:20           ` Thomas Gleixner
2026-01-12 11:20             ` Marc Zyngier
2026-01-12 14:08               ` Sebastian Andrzej Siewior
2026-01-12 14:38                 ` Marc Zyngier
2026-01-21  8:38               ` Marc Zyngier
2026-01-21 16:48                 ` Waiman Long
2026-01-21 20:41                 ` Waiman Long
2026-01-22  3:49                   ` Waiman Long
2026-03-09 19:06                     ` Waiman Long
2026-03-10  8:12                       ` Marc Zyngier
2026-01-11 23:02           ` Waiman Long
2026-01-12 15:09             ` Thomas Gleixner
2026-01-12 17:14               ` Waiman Long
2026-01-13 11:55                 ` Sebastian Andrzej Siewior
2026-01-13 23:25                   ` Alexei Starovoitov
2026-01-14 16:01                     ` Sebastian Andrzej Siewior
2026-01-14 17:59                   ` Vlastimil Babka
2026-01-21 16:37                     ` Waiman Long [this message]
2026-01-10 21:47   ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8ba00be-d98c-4962-a32a-98ac0ddef9b2@redhat.com \
    --to=llong@redhat.com \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®