From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Jack Pham <jack.pham@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Abel Vesa <abel.vesa@oss.qualcomm.com>
Subject: Re: [PATCH] soc: qcom: pmic_glink_altmode: Fix SVID=DP && unconnected edge case
Date: Mon, 9 Mar 2026 11:38:04 +0100 [thread overview]
Message-ID: <f8c968d0-0668-424f-9f5d-8ddd1b6f3fab@oss.qualcomm.com> (raw)
In-Reply-To: <7fcbf142-f2c6-4b9e-bb63-befa553aceff@linaro.org>
On 3/6/26 3:47 PM, Neil Armstrong wrote:
> On 3/6/26 12:20, Konrad Dybcio wrote:[...]
> So what's the difference with :
>
>
> if (blah)
> ...
> else (alt_port->svid == USB_TYPEC_DP_SID) {
> if (alt_port->mux_ctrl == MUX_CTRL_STATE_NO_CONN)
> pmic_glink_altmode_safe()
> else
> pmic_glink_altmode_enable_dp
> }
> else (blah)
> ...
> else (blah)
> ...
> else (alt_port->mux_ctrl == MUX_CTRL_STATE_NO_CONN)
> pmic_glink_altmode_safe()
>
>
> Before, if mux_ctrl was MUX_CTRL_STATE_NO_CONN, it would set to safe mode whatever the svid,
> now it's either in the DP case or at the end.
>
> I don't see the difference here, except if your desire is to ignore
> the MUX_CTRL_STATE_NO_CONN for USB_TYPEC_TBT_SID and MUX_CTRL_STATE_TUNNELING.
>
> But it doesn't match the commit message at all.
The difference is the call to drm_aux_hpd_bridge_notify() in the DP
case, which isn't very visible in the patch diff.
Konrad
next prev parent reply other threads:[~2026-03-09 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 11:20 Konrad Dybcio
2026-03-06 14:47 ` Neil Armstrong
2026-03-09 10:38 ` Konrad Dybcio [this message]
2026-03-09 10:43 ` Neil Armstrong
2026-03-09 10:58 ` Konrad Dybcio
2026-03-16 2:02 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8c968d0-0668-424f-9f5d-8ddd1b6f3fab@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=jack.pham@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®