From: Jens Axboe <axboe@kernel.dk>
To: Dylan Yudaken <dylany@fb.com>,
Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 0/4] io_uring: consistent behaviour with linked read/write
Date: Mon, 21 Feb 2022 09:33:35 -0700 [thread overview]
Message-ID: <f8f591d7-09c8-c537-ea41-30e0b33e29a3@kernel.dk> (raw)
In-Reply-To: <20220221141649.624233-1-dylany@fb.com>
On 2/21/22 7:16 AM, Dylan Yudaken wrote:
> Currently submitting multiple read/write for one file with offset = -1 will
> not behave as if calling read(2)/write(2) multiple times. The offset may be
> pinned to the same value for each submission (for example if they are
> punted to the async worker) and so each read/write will have the same
> offset.
>
> This patch series fixes this.
>
> Patch 1,3 cleans up the code a bit
>
> Patch 2 grabs the file position at execution time, rather than when the job
> is queued to be run which fixes inconsistincies when jobs are run asynchronously.
>
> Patch 4 increments the file's f_pos when reading it, which fixes
> inconsistincies with concurrent runs.
>
> A test for this will be submitted to liburing separately.
Looks good to me, but the patch 2 change will bubble through to patch 3
and 4 as well. Care to respin a v3?
--
Jens Axboe
next prev parent reply other threads:[~2022-02-21 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 14:16 Dylan Yudaken
2022-02-21 14:16 ` [PATCH v2 1/4] io_uring: remove duplicated calls to io_kiocb_ppos Dylan Yudaken
2022-02-21 14:16 ` [PATCH v2 2/4] io_uring: update kiocb->ki_pos at execution time Dylan Yudaken
2022-02-21 16:32 ` Jens Axboe
2022-02-21 14:16 ` [PATCH v2 3/4] io_uring: do not recalculate ppos unnecessarily Dylan Yudaken
2022-02-21 14:16 ` [PATCH v2 4/4] io_uring: pre-increment f_pos on rw Dylan Yudaken
2022-02-21 18:00 ` Pavel Begunkov
2022-02-22 7:20 ` Hao Xu
2022-02-22 8:26 ` Dylan Yudaken
2022-02-22 7:34 ` Hao Xu
2022-02-22 10:52 ` Dylan Yudaken
2022-02-21 16:33 ` Jens Axboe [this message]
2022-02-21 17:48 ` [PATCH v2 0/4] io_uring: consistent behaviour with linked read/write Dylan Yudaken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f591d7-09c8-c537-ea41-30e0b33e29a3@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dylany@fb.com \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®