* [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()
@ 2024-11-12 10:23 Dan Carpenter
2024-11-12 10:24 ` Biju Das
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2024-11-12 10:23 UTC (permalink / raw)
To: Liu Ying
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Biju Das, dri-devel, linux-kernel, kernel-janitors
If devm_i2c_new_dummy_device() fails then we were supposed to return an
error code, but instead the function continues and will crash on the next
line. Add the missing return statement.
Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/bridge/ite-it6263.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
index cbabd4e20d3e..5f138a5692c7 100644
--- a/drivers/gpu/drm/bridge/ite-it6263.c
+++ b/drivers/gpu/drm/bridge/ite-it6263.c
@@ -845,8 +845,8 @@ static int it6263_probe(struct i2c_client *client)
it->lvds_i2c = devm_i2c_new_dummy_device(dev, client->adapter,
LVDS_INPUT_CTRL_I2C_ADDR);
if (IS_ERR(it->lvds_i2c))
- dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),
- "failed to allocate I2C device for LVDS\n");
+ return dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),
+ "failed to allocate I2C device for LVDS\n");
it->lvds_regmap = devm_regmap_init_i2c(it->lvds_i2c,
&it6263_lvds_regmap_config);
--
2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()
2024-11-12 10:23 [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe() Dan Carpenter
@ 2024-11-12 10:24 ` Biju Das
2024-11-13 1:59 ` Liu Ying
2025-01-15 3:47 ` Liu Ying
2 siblings, 0 replies; 4+ messages in thread
From: Biju Das @ 2024-11-12 10:24 UTC (permalink / raw)
To: Dan Carpenter, Liu Ying
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, laurent.pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
dri-devel, linux-kernel, kernel-janitors
Hi Dan Carpenter,
Thanks for the patch.
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: 12 November 2024 10:23
> Subject: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()
>
> If devm_i2c_new_dummy_device() fails then we were supposed to return an error code, but instead the
> function continues and will crash on the next line. Add the missing return statement.
>
> Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Cheers,
Biju
> ---
> drivers/gpu/drm/bridge/ite-it6263.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/ite-it6263.c
> index cbabd4e20d3e..5f138a5692c7 100644
> --- a/drivers/gpu/drm/bridge/ite-it6263.c
> +++ b/drivers/gpu/drm/bridge/ite-it6263.c
> @@ -845,8 +845,8 @@ static int it6263_probe(struct i2c_client *client)
> it->lvds_i2c = devm_i2c_new_dummy_device(dev, client->adapter,
> LVDS_INPUT_CTRL_I2C_ADDR);
> if (IS_ERR(it->lvds_i2c))
> - dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),
> - "failed to allocate I2C device for LVDS\n");
> + return dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c),
> + "failed to allocate I2C device for LVDS\n");
>
> it->lvds_regmap = devm_regmap_init_i2c(it->lvds_i2c,
> &it6263_lvds_regmap_config);
> --
> 2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()
2024-11-12 10:23 [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe() Dan Carpenter
2024-11-12 10:24 ` Biju Das
@ 2024-11-13 1:59 ` Liu Ying
2025-01-15 3:47 ` Liu Ying
2 siblings, 0 replies; 4+ messages in thread
From: Liu Ying @ 2024-11-13 1:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Biju Das, dri-devel, linux-kernel, kernel-janitors
On 11/12/2024, Dan Carpenter wrote:
> If devm_i2c_new_dummy_device() fails then we were supposed to return an
> error code, but instead the function continues and will crash on the next
> line. Add the missing return statement.
>
> Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/bridge/ite-it6263.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Liu Ying <victor.liu@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()
2024-11-12 10:23 [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe() Dan Carpenter
2024-11-12 10:24 ` Biju Das
2024-11-13 1:59 ` Liu Ying
@ 2025-01-15 3:47 ` Liu Ying
2 siblings, 0 replies; 4+ messages in thread
From: Liu Ying @ 2025-01-15 3:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Biju Das, dri-devel, linux-kernel, kernel-janitors
On 11/12/2024, Dan Carpenter wrote:
> If devm_i2c_new_dummy_device() fails then we were supposed to return an
> error code, but instead the function continues and will crash on the next
> line. Add the missing return statement.
>
> Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/bridge/ite-it6263.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to misc/kernel.git (drm-misc-fixes).
Thanks!
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-15 3:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-12 10:23 [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe() Dan Carpenter
2024-11-12 10:24 ` Biju Das
2024-11-13 1:59 ` Liu Ying
2025-01-15 3:47 ` Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®