From: Guenter Roeck <linux@roeck-us.net>
To: Amna Waseem <Amna.Waseem@axis.com>
Cc: Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: ti,ina2xx: Add ti,alert-polarity-active-high property
Date: Wed, 12 Jun 2024 07:14:39 -0700 [thread overview]
Message-ID: <f960ba3e-6673-41ae-b58e-5b6b2e700082@roeck-us.net> (raw)
In-Reply-To: <20240603-apol-ina2xx-fix-v3-1-b9eff3158e4e@axis.com>
On Mon, Jun 03, 2024 at 12:08:34PM +0200, Amna Waseem wrote:
> Add a property to the binding to configure the Alert Polarity.
> Alert pin is asserted based on the value of Alert Polarity bit of
> Mask/Enable register. It is by default 0 which means Alert pin is
> configured to be active low open collector. Value of 1 maps to
> Inverted (active high open collector).
>
> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Applied.
Note this is v3 which includes the Reviewed-by: tag since v4
does not have any other changes.
I removed the trailing whitespace while applying the patch.
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> index df86c2c92037..9190ef0bda54 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> @@ -66,6 +66,14 @@ properties:
> description: phandle to the regulator that provides the VS supply typically
> in range from 2.7 V to 5.5 V.
>
> + ti,alert-polarity-active-high:
> + description: Alert pin is asserted based on the value of Alert polarity Bit
> + of Mask/Enable register. Default value is Normal (0 which maps to
> + active-low open collector). The other value is Inverted
> + (1 which maps to active-high open collector). Specify this property to set
> + the alert polarity to active-high.
> + $ref: /schemas/types.yaml#/definitions/flag
> +
> required:
> - compatible
> - reg
> @@ -88,5 +96,6 @@ examples:
> label = "vdd_3v0";
> shunt-resistor = <1000>;
> vs-supply = <&vdd_3v0>;
> + ti,alert-polarity-active-high;
> };
> };
next prev parent reply other threads:[~2024-06-12 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 10:08 [PATCH v3 0/2] hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver Amna Waseem
2024-06-03 10:08 ` [PATCH v3 1/2] dt-bindings: hwmon: ti,ina2xx: Add ti,alert-polarity-active-high property Amna Waseem
2024-06-05 23:31 ` Rob Herring (Arm)
2024-06-12 14:14 ` Guenter Roeck [this message]
2024-06-03 10:08 ` [PATCH v3 2/2] hwmon: (ina2xx) Add device tree support to pass alert polarity Amna Waseem
2024-06-10 16:29 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f960ba3e-6673-41ae-b58e-5b6b2e700082@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Amna.Waseem@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®