mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	mrungta@google.com, Wim Van Sebroeck <wim@linux-watchdog.org>,
	Thomas Gleixner <tglx@kernel.org>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	"Kirill A. Shutemov" <kas@kernel.org>,
	Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 3/3] watchdog: qcom: Register pretimeout interrupt as NMI
Date: Fri, 31 Jul 2026 07:12:52 -0700	[thread overview]
Message-ID: <f98f6f9c-9cfc-4fb6-8a1a-776b480bbad3@roeck-us.net> (raw)
In-Reply-To: <36a7bd8e-7e00-4df0-abd4-e22b86e91ca4@oss.qualcomm.com>

On 7/31/26 04:56, Konrad Dybcio wrote:
> On 7/30/26 11:32 PM, Mayank Rungta via B4 Relay wrote:
>> From: Mayank Rungta <mrungta@google.com>
>>
>> When a system is completely unresponsive due to an interrupt storm or
>> deadlocked CPU cores with standard interrupts disabled, a standard watchdog
>> pretimeout bark interrupt will fail to execute, preventing the pretimeout
>> governor from capturing CPU backtraces before the hardware reset bite.
> 
> [...]
> 
>>   drivers/watchdog/qcom-wdt.c | 55 +++++++++++++++++++++++++++++++++++++++++----
>>   1 file changed, 51 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c
>> index 49bd04841f0c..19d8e91cff40 100644
>> --- a/drivers/watchdog/qcom-wdt.c
>> +++ b/drivers/watchdog/qcom-wdt.c
>> @@ -51,6 +51,9 @@ struct qcom_wdt {
>>   	unsigned long		rate;
>>   	void __iomem		*base;
>>   	const u32		*layout;
>> +	int			irq;
>> +	bool			is_nmi;
>> +	bool			irq_enabled;
> 
> Do we need to track this? I think we can rely on the framework
> NOPing out multiple ops->start requests
> 
Good point. Agreed.

Guenter


  reply	other threads:[~2026-07-31 14:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 21:32 [PATCH 0/3] watchdog: qcom: Support NMI pretimeout warnings Mayank Rungta via B4 Relay
2026-07-30 21:32 ` [PATCH 1/3] watchdog: pretimeout: Protect governor access with RCU for NMI safety Mayank Rungta via B4 Relay
2026-07-30 21:46   ` Doug Anderson
2026-08-07  5:34     ` Guenter Roeck
2026-07-30 21:32 ` [PATCH 2/3] genirq: Export NMI APIs Mayank Rungta via B4 Relay
2026-07-30 21:49   ` Doug Anderson
2026-07-30 22:55     ` Guenter Roeck
2026-07-31 23:18       ` Doug Anderson
2026-08-07 16:00         ` Thomas Gleixner
2026-08-25  0:00           ` Mayank Rungta
2026-08-25 20:01             ` Thomas Gleixner
2026-07-30 21:32 ` [PATCH 3/3] watchdog: qcom: Register pretimeout interrupt as NMI Mayank Rungta via B4 Relay
2026-07-30 21:52   ` Doug Anderson
2026-07-31 11:56   ` Konrad Dybcio
2026-07-31 14:12     ` Guenter Roeck [this message]
2026-07-31 23:54       ` Mayank Rungta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f98f6f9c-9cfc-4fb6-8a1a-776b480bbad3@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=dianders@chromium.org \
    --cc=kas@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mrungta@google.com \
    --cc=tglx@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®