From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: David Airlie <airlied@linux.ie>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/omap: remove unneeded conversions to bool
Date: Thu, 11 Aug 2016 13:03:14 +0300 [thread overview]
Message-ID: <f9ae8a97-9dc5-dc2a-576f-365f9a0aff45@ti.com> (raw)
In-Reply-To: <20160701142721.17096-1-afd@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]
On 01/07/16 17:27, Andrew F. Davis wrote:
> Found with scripts/coccinelle/misc/boolconv.cocci.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index f83608b..495094b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -1655,7 +1655,7 @@ static void dispc_ovl_set_scaling_uv(enum omap_plane plane,
> {
> int scale_x = out_width != orig_width;
> int scale_y = out_height != orig_height;
> - bool chroma_upscale = plane != OMAP_DSS_WB ? true : false;
> + bool chroma_upscale = plane != OMAP_DSS_WB;
>
> if (!dss_has_feature(FEAT_HANDLE_UV_SEPARATE))
> return;
> @@ -3086,9 +3086,9 @@ static bool _dispc_mgr_pclk_ok(enum omap_channel channel,
> unsigned long pclk)
> {
> if (dss_mgr_is_lcd(channel))
> - return pclk <= dispc.feat->max_lcd_pclk ? true : false;
> + return pclk <= dispc.feat->max_lcd_pclk;
> else
> - return pclk <= dispc.feat->max_tv_pclk ? true : false;
> + return pclk <= dispc.feat->max_tv_pclk;
> }
>
> bool dispc_mgr_timings_ok(enum omap_channel channel,
>
Thanks, queued for v4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-11 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 14:27 Andrew F. Davis
2016-08-11 10:03 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9ae8a97-9dc5-dc2a-576f-365f9a0aff45@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=afd@ti.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®