From: Zijun Hu <zijun.hu@oss.qualcomm.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Zijun Hu <zijun_hu@icloud.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] Bluetooth: Add generic support for vendor HCI frames
Date: Wed, 22 Jul 2026 04:11:15 +0800 [thread overview]
Message-ID: <f9bbf92f-d617-468b-a5b4-2367a1d9a751@oss.qualcomm.com> (raw)
In-Reply-To: <CABBYNZJn2VvcNZq4xE2XS8ZZ5auVPTwB4W7q_Xpr9eNUALsfGw@mail.gmail.com>
On 7/22/2026 3:49 AM, Luiz Augusto von Dentz wrote:
> For the user channel I would say it would be better to always include
> 0xff. That way, it remains agnostic and it won't suddenly match a
> different packet type if you change the vendor or something like that.
so, perhaps, you original proposal(Option A) is better and easier to implement than this
simpler one since it uses consistent way to decide vendor HCI frame.
1)
userspace <-> kernel : 0xff + vendor hci indicator.
2)
for RX, transport driver stamp with HCI_VENDOR_PKT before hci_recv_frame()
For TX, transport driver pull one more byte(indicator) for HCI_VENDOR_PKT frame
tell type of vendor hci frames.
let me also give a implementation for this 'Option A' as well.
prev parent reply other threads:[~2026-07-21 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 5:13 Zijun Hu
2026-07-20 14:30 ` Luiz Augusto von Dentz
2026-07-21 8:52 ` Zijun Hu
2026-07-21 11:36 ` Zijun Hu
2026-07-21 14:22 ` Luiz Augusto von Dentz
2026-07-21 19:40 ` Zijun Hu
2026-07-21 19:49 ` Luiz Augusto von Dentz
2026-07-21 20:11 ` Zijun Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9bbf92f-d617-468b-a5b4-2367a1d9a751@oss.qualcomm.com \
--to=zijun.hu@oss.qualcomm.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®