[PATCH 0/2] Add initial support for RDP417 of IPQ9574 family

[PATCH 0/2] Add initial support for RDP417 of IPQ9574 family

[Sridharan S N]

Add the initial device tree support for the Reference Design
Platform(RDP) 454 based on IPQ9574 family of SoCs.

This series depends on below patchset:
https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/

This series depends on below patchset for CHECK_DTBS issue
https://lore.kernel.org/linux-arm-msm/20230526161129.1454-4-quic_anusha@quicinc.com/
Sridharan S N (2):
  dt-bindings: arm: qcom: document AL01-C1 board based on IPQ9574 family
  arm64: dts: qcom: ipq9574: add support for the RDP417 variant

 Documentation/devicetree/bindings/arm/qcom.yaml |  2 ++
 arch/arm64/boot/dts/qcom/Makefile               |  1 +
 arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts     | 16 ++++++++++++++++
 3 files changed, 19 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts

-- 
2.34.1

[PATCH 1/2] dt-bindings: arm: qcom: document AL01-C1 board based on IPQ9574 family

[Sridharan S N]

Document the AL01-C1 (Reference Design Platform 417) board based on IPQ9574
family of SoCs.

Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 450f616774e0..dd66fd872c31 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -87,6 +87,7 @@ description: |
   The 'board' element must be one of the following strings:
 
         adp
+        ap-al01-c1
         ap-al02-c2
         ap-al02-c6
         ap-al02-c7
@@ -362,6 +363,7 @@ properties:
 
       - items:
           - enum:
+              - qcom,ipq9574-ap-al01-c1
               - qcom,ipq9574-ap-al02-c2
               - qcom,ipq9574-ap-al02-c6
               - qcom,ipq9574-ap-al02-c7
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: arm: qcom: document AL01-C1 board based on IPQ9574 family

[Krzysztof Kozlowski]

On 13/07/2023 13:55, Sridharan S N wrote:
> Document the AL01-C1 (Reference Design Platform 417) board based on IPQ9574
> family of SoCs.
> 
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>  1 file changed, 2 insertions(+)


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant

[Sridharan S N]

Add the initial device tree support for the Reference Design
Platform(RDP) 417 based on IPQ9574 family of SoC.

This patch depends on below patchset:
https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/

Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
---
 arch/arm64/boot/dts/qcom/Makefile           |  1 +
 arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 337abc4ceb17..9c30344d08c1 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c2.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp417.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp418.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp433.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp449.dtb
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts
new file mode 100644
index 000000000000..9a5d4c3db1f2
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP417 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL01-C1";
+	compatible = "qcom,ipq9574-ap-al01-c1", "qcom,ipq9574";
+};
-- 
2.34.1

Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant

[Krzysztof Kozlowski]

On 13/07/2023 13:55, Sridharan S N wrote:
> Add the initial device tree support for the Reference Design
> Platform(RDP) 417 based on IPQ9574 family of SoC.
> 
> This patch depends on below patchset:
> https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/

This does not make sense in commit log. Why would you store it in commit
in the first place? Please put dependencies with changelog, so after ---
separator.

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant

[Sridharan S N]

On 7/13/2023 5:28 PM, Krzysztof Kozlowski wrote:
> On 13/07/2023 13:55, Sridharan S N wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 417 based on IPQ9574 family of SoC.
>>
>> This patch depends on below patchset:
>> https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/
> This does not make sense in commit log. Why would you store it in commit
> in the first place? Please put dependencies with changelog, so after ---
> separator.
>
> Best regards,
> Krzysztof

Sorry,I overlooked it. Will move the dependencies to change log and post v2


Thanks,

Sridharan

>