From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: sequencing: pwrseq-pcie-m2: Drop undocumented QCC2072 compatible
Date: Fri, 24 Jul 2026 10:24:15 +0200 [thread overview]
Message-ID: <f9fe60ca-b801-4915-b7a6-8d4b1a2acf9a@oss.qualcomm.com> (raw)
In-Reply-To: <CAMRc=Mc=4BkXsv2efKipwTq_qXx8m0tH2RPTF6vtZjpE_maaCg@mail.gmail.com>
On 24/07/2026 09:39, Bartosz Golaszewski wrote:
> On Thu, 23 Jul 2026 21:35:26 +0200, Krzysztof Kozlowski
> <krzysztof.kozlowski@oss.qualcomm.com> said:
>> There is no such compatible documented (thus allowed) as
>> qcom,qcc2072-bt, thus it should not be added even in driver match data,
>> which later is used for compatible matching.
>>
>> Revert commit 162ea02941a9 ("power: sequencing: pwrseq-pcie-m2: Add
>> QCC2072 BT PCI device ID").
>>
>> Cc: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>> drivers/power/sequencing/pwrseq-pcie-m2.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c
>> index 83fe6a1396bc..168e915f2c89 100644
>> --- a/drivers/power/sequencing/pwrseq-pcie-m2.c
>> +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c
>> @@ -195,8 +195,6 @@ static const struct pci_device_id pwrseq_m2_pci_ids[] = {
>> .driver_data = (kernel_ulong_t)"qcom,wcn6855-bt" },
>> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1107),
>> .driver_data = (kernel_ulong_t)"qcom,wcn7850-bt" },
>> - { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1112),
>> - .driver_data = (kernel_ulong_t)"qcom,qcc2072-bt" },
>> { } /* Sentinel */
>> };
>>
>> --
>> 2.53.0
>>
>>
>
> This is the top commit in my queue so I just dropped it entirely, otherwise it
> would be an addition followed by a revert which could raise Linus' eyebrow.
Thanks, this works for me. I expect the commit to be resent/reapplied at
some point when the compatible is documented.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-07-24 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 19:35 Krzysztof Kozlowski
2026-07-24 7:39 ` Bartosz Golaszewski
2026-07-24 8:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9fe60ca-b801-4915-b7a6-8d4b1a2acf9a@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®