mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] power: sequencing: pwrseq-pcie-m2: Drop undocumented QCC2072 compatible
@ 2026-07-23 19:35 Krzysztof Kozlowski
  2026-07-24  7:39 ` Bartosz Golaszewski
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-23 19:35 UTC (permalink / raw)
  To: Manivannan Sadhasivam, Bartosz Golaszewski, linux-pci, linux-pm,
	linux-kernel
  Cc: Krzysztof Kozlowski, Krishna Chaitanya Chundru

There is no such compatible documented (thus allowed) as
qcom,qcc2072-bt, thus it should not be added even in driver match data,
which later is used for compatible matching.

Revert commit 162ea02941a9 ("power: sequencing: pwrseq-pcie-m2: Add
QCC2072 BT PCI device ID").

Cc: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/power/sequencing/pwrseq-pcie-m2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c
index 83fe6a1396bc..168e915f2c89 100644
--- a/drivers/power/sequencing/pwrseq-pcie-m2.c
+++ b/drivers/power/sequencing/pwrseq-pcie-m2.c
@@ -195,8 +195,6 @@ static const struct pci_device_id pwrseq_m2_pci_ids[] = {
 	  .driver_data = (kernel_ulong_t)"qcom,wcn6855-bt" },
 	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1107),
 	  .driver_data = (kernel_ulong_t)"qcom,wcn7850-bt" },
-	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1112),
-	  .driver_data = (kernel_ulong_t)"qcom,qcc2072-bt" },
 	{ } /* Sentinel */
 };
 
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] power: sequencing: pwrseq-pcie-m2: Drop undocumented QCC2072 compatible
  2026-07-23 19:35 [PATCH] power: sequencing: pwrseq-pcie-m2: Drop undocumented QCC2072 compatible Krzysztof Kozlowski
@ 2026-07-24  7:39 ` Bartosz Golaszewski
  2026-07-24  8:24   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-07-24  7:39 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Krishna Chaitanya Chundru, Manivannan Sadhasivam,
	Bartosz Golaszewski, linux-pci, linux-pm, linux-kernel

On Thu, 23 Jul 2026 21:35:26 +0200, Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> said:
> There is no such compatible documented (thus allowed) as
> qcom,qcc2072-bt, thus it should not be added even in driver match data,
> which later is used for compatible matching.
>
> Revert commit 162ea02941a9 ("power: sequencing: pwrseq-pcie-m2: Add
> QCC2072 BT PCI device ID").
>
> Cc: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  drivers/power/sequencing/pwrseq-pcie-m2.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c
> index 83fe6a1396bc..168e915f2c89 100644
> --- a/drivers/power/sequencing/pwrseq-pcie-m2.c
> +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c
> @@ -195,8 +195,6 @@ static const struct pci_device_id pwrseq_m2_pci_ids[] = {
>  	  .driver_data = (kernel_ulong_t)"qcom,wcn6855-bt" },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1107),
>  	  .driver_data = (kernel_ulong_t)"qcom,wcn7850-bt" },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1112),
> -	  .driver_data = (kernel_ulong_t)"qcom,qcc2072-bt" },
>  	{ } /* Sentinel */
>  };
>
> --
> 2.53.0
>
>

This is the top commit in my queue so I just dropped it entirely, otherwise it
would be an addition followed by a revert which could raise Linus' eyebrow.

Bart

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] power: sequencing: pwrseq-pcie-m2: Drop undocumented QCC2072 compatible
  2026-07-24  7:39 ` Bartosz Golaszewski
@ 2026-07-24  8:24   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-24  8:24 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Krishna Chaitanya Chundru, Manivannan Sadhasivam, linux-pci,
	linux-pm, linux-kernel

On 24/07/2026 09:39, Bartosz Golaszewski wrote:
> On Thu, 23 Jul 2026 21:35:26 +0200, Krzysztof Kozlowski
> <krzysztof.kozlowski@oss.qualcomm.com> said:
>> There is no such compatible documented (thus allowed) as
>> qcom,qcc2072-bt, thus it should not be added even in driver match data,
>> which later is used for compatible matching.
>>
>> Revert commit 162ea02941a9 ("power: sequencing: pwrseq-pcie-m2: Add
>> QCC2072 BT PCI device ID").
>>
>> Cc: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>>  drivers/power/sequencing/pwrseq-pcie-m2.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c
>> index 83fe6a1396bc..168e915f2c89 100644
>> --- a/drivers/power/sequencing/pwrseq-pcie-m2.c
>> +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c
>> @@ -195,8 +195,6 @@ static const struct pci_device_id pwrseq_m2_pci_ids[] = {
>>  	  .driver_data = (kernel_ulong_t)"qcom,wcn6855-bt" },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1107),
>>  	  .driver_data = (kernel_ulong_t)"qcom,wcn7850-bt" },
>> -	{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x1112),
>> -	  .driver_data = (kernel_ulong_t)"qcom,qcc2072-bt" },
>>  	{ } /* Sentinel */
>>  };
>>
>> --
>> 2.53.0
>>
>>
> 
> This is the top commit in my queue so I just dropped it entirely, otherwise it
> would be an addition followed by a revert which could raise Linus' eyebrow.

Thanks, this works for me. I expect the commit to be resent/reapplied at
some point when the compatible is documented.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-24  8:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-23 19:35 [PATCH] power: sequencing: pwrseq-pcie-m2: Drop undocumented QCC2072 compatible Krzysztof Kozlowski
2026-07-24  7:39 ` Bartosz Golaszewski
2026-07-24  8:24   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®