From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>,
Priyansh Jain <priyansh.jain@oss.qualcomm.com>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] thermal: qcom: tsens: Disable wakeup interrupt setup on automotive targets
Date: Tue, 16 Jun 2026 13:46:09 +0200 [thread overview]
Message-ID: <fa071c6e-2529-4410-a5b3-3c077d4cea99@oss.qualcomm.com> (raw)
In-Reply-To: <5b990bd7-e234-49eb-b5ae-5ec117fdf2d5@oss.qualcomm.com>
On 6/3/26 2:27 PM, Daniel Lezcano wrote:
> On 6/3/26 14:25, Konrad Dybcio wrote:
>>
>>
>> On 01-Jun-26 08:37, Priyansh Jain wrote:
>>> Add a no_irq_wake flag to struct tsens_plat_data to allow platforms
>>> to control whether TSENS interrupts should be configured as wakeup
>>> sources.
>>>
>>> Create a new data_automotive structure and add compatible strings for
>>> automotive TSENS variants (SA8775P, SA8255P) with wakeup interrupts
>>> disabled.
>>>
>>> Automotive platforms can enter a low-power parking suspend state where the
>>> application processors and thermal mitigation paths are not active. In this
>>> state, waking the system due to TSENS threshold interrupts does not enable
>>> useful thermal action, but it does repeatedly break suspend residency and
>>> increase battery drain.
>>>
>>> Allow these automotive variants to keep TSENS monitoring enabled during
>>> normal runtime while opting out of TSENS wakeup interrupts during suspend,
>>> so the system can remain in low power until ignition/resume.
>>
>> Can you not just disable the wakeup source via sysfs for
>> your needs?
>
> AFAIU, the system will crash for this version, so it has to be disabled
I can't see a mention of this in the commit message, but if it's the case,
it should most definitely be there in writing..
Konrad
next prev parent reply other threads:[~2026-06-16 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 6:37 [PATCH v2 0/2] thermal: qcom: tsens: refine wake IRQ handling for suspend Priyansh Jain
2026-06-01 6:37 ` [PATCH v2 1/2] thermal: qcom: tsens: switch wake IRQ handling to PM callbacks Priyansh Jain
2026-06-01 6:37 ` [PATCH v2 2/2] thermal: qcom: tsens: Disable wakeup interrupt setup on automotive targets Priyansh Jain
2026-06-03 12:25 ` Konrad Dybcio
2026-06-03 12:27 ` Daniel Lezcano
2026-06-16 11:46 ` Konrad Dybcio [this message]
2026-06-02 21:12 ` [PATCH v2 0/2] thermal: qcom: tsens: refine wake IRQ handling for suspend Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa071c6e-2529-4410-a5b3-3c077d4cea99@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=daniel.lezcano@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=priyansh.jain@oss.qualcomm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®