mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@collabora.com>
To: Amin Gattout <amin.gattout@gmail.com>,
	Mehdi Djait <mehdi.djait@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rockchip: rkcif: convert timeout to secs_to_jiffies()
Date: Fri, 18 Sep 2026 17:22:57 +0200	[thread overview]
Message-ID: <fa2f5b96-a44f-42b6-91b4-5895b57b4f53@collabora.com> (raw)
In-Reply-To: <20260918-rkcif-secs-to-jiffies-v1-1-110f336750b0@gmail.com>

Hi Amin,

Thanks for the patch!

On 9/18/26 15:05, Amin Gattout wrote:
> Use secs_to_jiffies() to simplify the code.
> 
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>

Acked-by: Michael Riesch <michael.riesch@collabora.com>

Best regards,
Michael

> ---
>  drivers/media/platform/rockchip/rkcif/rkcif-stream.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> index 3130d420ad55..f82eaf9a37d1 100644
> --- a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> +++ b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> @@ -314,7 +314,7 @@ static void rkcif_stream_stop_streaming(struct vb2_queue *queue)
>  
>  	stream->stopping = true;
>  	ret = wait_event_timeout(stream->wq_stopped, !stream->stopping,
> -				 msecs_to_jiffies(1000));
> +				 secs_to_jiffies(1));
>  
>  	if (!ret && stream->stop_streaming)
>  		stream->stop_streaming(stream);
> 
> ---
> base-commit: 238650ef6c7c7cca08e032527329424c9fbd70e5
> change-id: 20260918-rkcif-secs-to-jiffies-1b98a96465f7
> 
> Best regards,
> --  
> Amin Gattout <amin.gattout@gmail.com>
> 


      reply	other threads:[~2026-09-18 15:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 13:05 Amin Gattout
2026-09-18 15:22 ` Michael Riesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa2f5b96-a44f-42b6-91b4-5895b57b4f53@collabora.com \
    --to=michael.riesch@collabora.com \
    --cc=amin.gattout@gmail.com \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®