* [PATCH] media: rockchip: rkcif: convert timeout to secs_to_jiffies()
@ 2026-09-18 13:05 Amin Gattout
2026-09-18 15:22 ` Michael Riesch
0 siblings, 1 reply; 2+ messages in thread
From: Amin Gattout @ 2026-09-18 13:05 UTC (permalink / raw)
To: Mehdi Djait, Michael Riesch, Mauro Carvalho Chehab, Heiko Stuebner
Cc: linux-media, linux-arm-kernel, linux-rockchip, linux-kernel,
Amin Gattout
Use secs_to_jiffies() to simplify the code.
Signed-off-by: Amin Gattout <amin.gattout@gmail.com>
---
drivers/media/platform/rockchip/rkcif/rkcif-stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
index 3130d420ad55..f82eaf9a37d1 100644
--- a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
+++ b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
@@ -314,7 +314,7 @@ static void rkcif_stream_stop_streaming(struct vb2_queue *queue)
stream->stopping = true;
ret = wait_event_timeout(stream->wq_stopped, !stream->stopping,
- msecs_to_jiffies(1000));
+ secs_to_jiffies(1));
if (!ret && stream->stop_streaming)
stream->stop_streaming(stream);
---
base-commit: 238650ef6c7c7cca08e032527329424c9fbd70e5
change-id: 20260918-rkcif-secs-to-jiffies-1b98a96465f7
Best regards,
--
Amin Gattout <amin.gattout@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rockchip: rkcif: convert timeout to secs_to_jiffies()
2026-09-18 13:05 [PATCH] media: rockchip: rkcif: convert timeout to secs_to_jiffies() Amin Gattout
@ 2026-09-18 15:22 ` Michael Riesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Riesch @ 2026-09-18 15:22 UTC (permalink / raw)
To: Amin Gattout, Mehdi Djait, Mauro Carvalho Chehab, Heiko Stuebner
Cc: linux-media, linux-arm-kernel, linux-rockchip, linux-kernel
Hi Amin,
Thanks for the patch!
On 9/18/26 15:05, Amin Gattout wrote:
> Use secs_to_jiffies() to simplify the code.
>
> Signed-off-by: Amin Gattout <amin.gattout@gmail.com>
Acked-by: Michael Riesch <michael.riesch@collabora.com>
Best regards,
Michael
> ---
> drivers/media/platform/rockchip/rkcif/rkcif-stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> index 3130d420ad55..f82eaf9a37d1 100644
> --- a/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> +++ b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> @@ -314,7 +314,7 @@ static void rkcif_stream_stop_streaming(struct vb2_queue *queue)
>
> stream->stopping = true;
> ret = wait_event_timeout(stream->wq_stopped, !stream->stopping,
> - msecs_to_jiffies(1000));
> + secs_to_jiffies(1));
>
> if (!ret && stream->stop_streaming)
> stream->stop_streaming(stream);
>
> ---
> base-commit: 238650ef6c7c7cca08e032527329424c9fbd70e5
> change-id: 20260918-rkcif-secs-to-jiffies-1b98a96465f7
>
> Best regards,
> --
> Amin Gattout <amin.gattout@gmail.com>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-18 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-18 13:05 [PATCH] media: rockchip: rkcif: convert timeout to secs_to_jiffies() Amin Gattout
2026-09-18 15:22 ` Michael Riesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®