mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jijie Shao <shaojijie@huawei.com>
To: <linux@treblig.org>, <salil.mehta@huawei.com>,
	<shenjian15@huawei.com>, <andrew+netdev@lunn.ch>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>
Cc: <shaojijie@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 4/4] net: hisilicon: hns: Remove unused enums
Date: Thu, 19 Dec 2024 20:30:01 +0800	[thread overview]
Message-ID: <fa410af0-e4b0-4199-8f2a-960399e54d82@huawei.com> (raw)
In-Reply-To: <20241218163341.40297-5-linux@treblig.org>


on 2024/12/19 0:33, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The enums dsaf_roce_port_mode, dsaf_roce_port_num and dsaf_roce_qos_sl
> are unused after the removal of the reset code.
>
> Remove them.

Thanks,

Reviewed-by: Jijie Shao<shaojijie@huawei.com>


>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   .../ethernet/hisilicon/hns/hns_dsaf_main.h    | 23 -------------------
>   1 file changed, 23 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> index bb8267aafc43..653dfbb25d1b 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> @@ -42,29 +42,6 @@ struct hns_mac_cb;
>   
>   #define HNS_MAX_WAIT_CNT 10000
>   
> -enum dsaf_roce_port_mode {
> -	DSAF_ROCE_6PORT_MODE,
> -	DSAF_ROCE_4PORT_MODE,
> -	DSAF_ROCE_2PORT_MODE,
> -	DSAF_ROCE_CHAN_MODE_NUM,
> -};
> -
> -enum dsaf_roce_port_num {
> -	DSAF_ROCE_PORT_0,
> -	DSAF_ROCE_PORT_1,
> -	DSAF_ROCE_PORT_2,
> -	DSAF_ROCE_PORT_3,
> -	DSAF_ROCE_PORT_4,
> -	DSAF_ROCE_PORT_5,
> -};
> -
> -enum dsaf_roce_qos_sl {
> -	DSAF_ROCE_SL_0,
> -	DSAF_ROCE_SL_1,
> -	DSAF_ROCE_SL_2,
> -	DSAF_ROCE_SL_3,
> -};
> -
>   #define DSAF_STATS_READ(p, offset) (*((u64 *)((u8 *)(p) + (offset))))
>   #define HNS_DSAF_IS_DEBUG(dev) ((dev)->dsaf_mode == DSAF_MODE_DISABLE_SP)
>   

  reply	other threads:[~2024-12-19 12:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 16:33 [PATCH net-next v2 0/4] hisilicon hns deadcoding linux
2024-12-18 16:33 ` [PATCH net-next v2 1/4] net: hisilicon: hns: Remove unused hns_dsaf_roce_reset linux
2024-12-19 12:28   ` Jijie Shao
2024-12-18 16:33 ` [PATCH net-next v2 2/4] net: hisilicon: hns: Remove unused hns_rcb_start linux
2024-12-18 16:33 ` [PATCH net-next v2 3/4] net: hisilicon: hns: Remove reset helpers linux
2024-12-18 16:33 ` [PATCH net-next v2 4/4] net: hisilicon: hns: Remove unused enums linux
2024-12-19 12:30   ` Jijie Shao [this message]
2024-12-20 21:30 ` [PATCH net-next v2 0/4] hisilicon hns deadcoding patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa410af0-e4b0-4199-8f2a-960399e54d82@huawei.com \
    --to=shaojijie@huawei.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=salil.mehta@huawei.com \
    --cc=shenjian15@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®