* Re: [PATCH v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind()
@ 2020-04-30 11:56 Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-04-30 11:56 UTC (permalink / raw)
To: Wei Yongjun, dri-devel
Cc: kernel-janitors, linux-kernel, Daniel Vetter, David Airlie,
Linus Walleij
> The of_drm_find_bridge() function returns NULL on error, it doesn't return
> error pointers so this check doesn't work.
How do you think about a wording variant like the following?
Change description:
An error pointer check was performed after a call of the
function “of_drm_find_bridge” despite of the detail
that failures are indicated for the bridge search
by null pointers instead.
Thus adjust a check for the failure predicate
and the corresponding exception handling.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind()
@ 2020-04-30 11:56 Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-04-30 11:56 UTC (permalink / raw)
To: Wei Yongjun, dri-devel
Cc: kernel-janitors, linux-kernel, Daniel Vetter, David Airlie,
Linus Walleij
> The of_drm_find_bridge() function returns NULL on error, it doesn't return
> error pointers so this check doesn't work.
How do you think about a wording variant like the following?
Change description:
An error pointer check was performed after a call of the
function “of_drm_find_bridge” despite of the detail
that failures are indicated for the bridge search
by null pointers instead.
Thus adjust a check for the failure predicate
and the corresponding exception handling.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-30 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 11:56 [PATCH v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind() Markus Elfring
2020-04-30 11:56 Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®